Re: [PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

2014-04-03 Thread Michael Haggerty
On 04/03/2014 05:57 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> I assumed that rolling back a non-consummated transaction in the case of >> early program death should be the responsibility of the library, not of >> the caller. If I'm correct, the caller(s) won't have to be modified

Re: [PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

2014-04-03 Thread Junio C Hamano
Michael Haggerty writes: > I assumed that rolling back a non-consummated transaction in the case of > early program death should be the responsibility of the library, not of > the caller. If I'm correct, the caller(s) won't have to be modified > when the atexit facility is added, so I don't see

Re: [PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

2014-04-01 Thread Michael Haggerty
On 04/01/2014 09:46 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> This change is mostly clerical: the parse_cmd_*() functions need to >> use local variables rather than a struct ref_update to collect the >> arguments needed for each update, and then call ref_transaction_*() to >> queu

Re: [PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

2014-04-01 Thread Junio C Hamano
Michael Haggerty writes: > This change is mostly clerical: the parse_cmd_*() functions need to > use local variables rather than a struct ref_update to collect the > arguments needed for each update, and then call ref_transaction_*() to > queue the change rather than building up the list of chang

[PATCH v2 20/27] update-ref --stdin: Reimplement using reference transactions

2014-03-24 Thread Michael Haggerty
This change is mostly clerical: the parse_cmd_*() functions need to use local variables rather than a struct ref_update to collect the arguments needed for each update, and then call ref_transaction_*() to queue the change rather than building up the list of changes at the caller side. Signed-off-