Re: [PATCH v2 4/6] send-email: make --suppress-cc=self sanitize input

2013-06-03 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > Yes, I think so too. So - what do you suggest? > Add a test? > Add a comment? > more? Nothing major comes to my mind at this moment. I guess it would be good to add a test or two to use "A U. Thor" example with and without end-user added quotes, but th

Re: [PATCH v2 4/6] send-email: make --suppress-cc=self sanitize input

2013-06-03 Thread Michael S. Tsirkin
On Mon, Jun 03, 2013 at 09:17:21AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > --suppress-cc=self fails to filter sender address in many cases where it > > needs to be sanitized in some way, for example quoted: > > "A U. Thor" > > To fix, make send-email sanitize both sende

Re: [PATCH v2 4/6] send-email: make --suppress-cc=self sanitize input

2013-06-03 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > --suppress-cc=self fails to filter sender address in many cases where it > needs to be sanitized in some way, for example quoted: > "A U. Thor" > To fix, make send-email sanitize both sender and the address it is > compared against. > > Signed-off-by: Michael S. Ts

[PATCH v2 4/6] send-email: make --suppress-cc=self sanitize input

2013-05-30 Thread Michael S. Tsirkin
--suppress-cc=self fails to filter sender address in many cases where it needs to be sanitized in some way, for example quoted: "A U. Thor" To fix, make send-email sanitize both sender and the address it is compared against. Signed-off-by: Michael S. Tsirkin --- git-send-email.perl | 18 +++