Re: [PATCH v2 5/5] Revert "repository: pre-initialize hash algo pointer"

On Sun, Feb 25, 2018 at 10:29:29AM +0700, Duy Nguyen wrote: > When I set unknown hash algo here, I think some test failed > mysteriously because it used rawsz field (which has value zero), it > didn't match some expectation, the code went to the error handling > path, which eventually failed with

Re: [PATCH v2 5/5] Revert "repository: pre-initialize hash algo pointer"

On Sun, Feb 25, 2018 at 5:58 AM, brian m. carlson wrote: >> diff --git a/repository.c b/repository.c >> index 4ffbe9bc94..0d715f4fdb 100644 >> --- a/repository.c >> +++ b/repository.c >> @@ -5,7 +5,7 @@ >> >> /* The main repository */ >> static struct repository

Re: [PATCH v2 5/5] Revert "repository: pre-initialize hash algo pointer"

On Sat, Feb 24, 2018 at 10:34:29AM +0700, Nguyễn Thái Ngọc Duy wrote: > This reverts commit e26f7f19b6c7485f04234946a59ab8f4fd21d6d1. The root > problem, git clone not setting up the_hash_algo, has been fixed in the > previous patch. > > Since this is a dangerous move and could potentially break

[PATCH v2 5/5] Revert "repository: pre-initialize hash algo pointer"

This reverts commit e26f7f19b6c7485f04234946a59ab8f4fd21d6d1. The root problem, git clone not setting up the_hash_algo, has been fixed in the previous patch. Since this is a dangerous move and could potentially break stuff after release (and leads to workaround like the reverted commit), the