Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Jeff King
On Sat, Oct 19, 2019 at 04:25:19PM +0100, Philip Oakley wrote: > > +int bitmap_walk_contains(struct bitmap_index *bitmap_git, > > +struct bitmap *bitmap, const struct object_id *oid) > > +{ > > + int idx; > Excuse my ignorance here... > > For the case on Windows (int/long 32

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
Hi Christian, On 19/10/2019 19:55, Christian Couder wrote: Hi Philip, On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote: Hi Christian, can I check one thing? Yeah, sure! Thanks for taking a look at my patches! On 19/10/2019 11:35, Christian Couder wrote: +int bitmap_walk_contains(struct

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Christian Couder
Hi Philip, On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote: > > Hi Christian, > can I check one thing? Yeah, sure! Thanks for taking a look at my patches! > On 19/10/2019 11:35, Christian Couder wrote: > > +int bitmap_walk_contains(struct bitmap_index *bitmap_git, > > +

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
Hi Christian, can I check one thing? On 19/10/2019 11:35, Christian Couder wrote: From: Jeff King We will use this helper function in a following commit to tell us if an object is packed. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- pack-bitmap.c | 12 pack-b

[PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Christian Couder
From: Jeff King We will use this helper function in a following commit to tell us if an object is packed. Signed-off-by: Jeff King Signed-off-by: Christian Couder --- pack-bitmap.c | 12 pack-bitmap.h | 3 +++ 2 files changed, 15 insertions(+) diff --git a/pack-bitmap.c b/pack-