Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

Max Horn writes: >> +buf = ident_line; >> if (split_ident_line(&ident, >> - buf + strlen("author "), >> - line_end - (buf + strlen("author "))) || >> + buf, >> +

Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

Tanay Abhra writes: > In record_author_date() & parse_gpg_output() ,using skip_prefix() instead of > starts_with() is a more suitable abstraction. Thanks. Will queue with a reworded message to clarify what exactly "A more suitable" means. Here is what I tentatively came up with. -- >8 -- From

Re: [PATCH v3] commit.c: use skip_prefix() instead of starts_with()

On 04.03.2014, at 09:42, Tanay Abhra wrote: [...] > commit.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/commit.c b/commit.c > index 6bf4fe0..6c92acb 100644 > --- a/commit.c > +++ b/commit.c [...] > @@ -566,14 +566,16 @@ static void record_author

[PATCH v3] commit.c: use skip_prefix() instead of starts_with()

In record_author_date() & parse_gpg_output() ,using skip_prefix() instead of starts_with() is a more suitable abstraction. Helped-by: Max Horn Helped-by: Junio C Hamano Helped-by: Michael Haggerty Signed-off-by: Tanay Abhra --- Patch V3 Variable naming improved, removed assignments inside con