Re: [PATCH v3] t9001: avoid not portable '\n' with sed

2014-06-10 Thread Junio C Hamano
Torsten Bögershausen writes: > I think that V3 explains the difference between POSIX sed and > gnu sed much better, and does reflect all the comments from > the list, which otherwise may be lost. Too late for that as the patch is already in 'next' X-<. -- To unsubscribe from this list: send th

Re: [PATCH v3] t9001: avoid not portable '\n' with sed

2014-06-09 Thread Torsten Bögershausen
On 06/10/2014 07:55 AM, Junio C Hamano wrote: Torsten Bögershausen writes: t9001 used a '\n' in a sed expression to split one line into two lines, but the usage of '\n' in the "replacement string" is not portable. This looks peculiarly familiar; don't I already have it queued? Yes, V2 is que

Re: [PATCH v3] t9001: avoid not portable '\n' with sed

2014-06-09 Thread Junio C Hamano
Torsten Bögershausen writes: > t9001 used a '\n' in a sed expression to split one line into two lines, > but the usage of '\n' in the "replacement string" is not portable. This looks peculiarly familiar; don't I already have it queued? -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v3] t9001: avoid not portable '\n' with sed

2014-06-09 Thread Eric Sunshine
On Tue, Jun 10, 2014 at 12:07 AM, Torsten Bögershausen wrote: > t9001 used a '\n' in a sed expression to split one line into two lines, > but the usage of '\n' in the "replacement string" is not portable. > > The '\n' can be used to match a newline in the "pattern space", > but otherwise the meani

[PATCH v3] t9001: avoid not portable '\n' with sed

2014-06-09 Thread Torsten Bögershausen
t9001 used a '\n' in a sed expression to split one line into two lines, but the usage of '\n' in the "replacement string" is not portable. The '\n' can be used to match a newline in the "pattern space", but otherwise the meaning of '\n' is unspecified in POSIX. - Gnu versions of sed will treat '\