[PATCH v3 00/13] nd/pretty-formats
I've been updating this series on and off over a long span of time, I don't think I remember exactly what changes I've made. But basically I think I have covered all comments from v2. The only semantics change is %C(auto) now turns auto coloring on for all following placeholders until another valid %C is encountered. Nguyễn Thái Ngọc Duy (13): pretty: save commit encoding from logmsg_reencode if the caller needs it pretty: get the correct encoding for --pretty:format=%e pretty-formats.txt: wrap long lines pretty: share code between format_decoration and show_decorations utf8.c: move display_mode_esc_sequence_len() for use by other functions utf8.c: add utf8_strnwidth() with the ability to skip ansi sequences utf8.c: add reencode_string_len() that can handle NULs in string pretty: two phase conversion for non utf-8 commits pretty: split color parsing into a separate function pretty: add %C(auto) for auto-coloring pretty: support padding placeholders, % % and % pretty: support truncating in %, % and % pretty: support % that steal trailing spaces Documentation/pretty-formats.txt | 35 +++- builtin/blame.c | 2 +- builtin/commit.c | 2 +- commit.h | 1 + compat/precompose_utf8.c | 2 +- log-tree.c | 48 -- log-tree.h | 1 + pretty.c | 349 --- revision.c | 2 +- t/t4205-log-pretty-formats.sh| 179 t/t4207-log-decoration-colors.sh | 8 +- t/t6006-rev-list-format.sh | 12 +- utf8.c | 104 +--- utf8.h | 23 ++- 14 files changed, 644 insertions(+), 124 deletions(-) -- 1.8.2.82.gc24b958 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 00/13] nd/pretty-formats
The short version: all applied, compiled and test OK. Possible minor nits from apply: applying: pretty: support padding placeholders, % % and % /Users/tb/projects/git/tb.duy/.git/rebase-apply/patch:253: indent with spaces. message two$ /Users/tb/projects/git/tb.duy/.git/rebase-apply/patch:254: indent with spaces. message one$ /Users/tb/projects/git/tb.duy/.git/rebase-apply/patch:255: indent with spaces. add bar$ /Users/tb/projects/git/tb.duy/.git/rebase-apply/patch:256: indent with spaces. initial$ /Users/tb/projects/git/tb.duy/.git/rebase-apply/patch:292: indent with spaces. message two $ warning: squelched 3 whitespace errors = And a possible micronit: what happened to that? On Sun, Mar 31, 2013 at 12:06 AM, Torsten Bögershausen tbo...@web.de wrote: On 30.03.13 10:35, Nguyễn Thái Ngọc Duy wrote: [...] The short version of a review: Would it make sense to leave reencode_string() as it is, and add a new function reencode_string_len() Hmm.. yeah. /Torsten -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
