Re: [PATCH v3 05/19] update-ref.c: use the error string from _commit to print better message

2014-04-28 Thread Ronnie Sahlberg
Good ideas. Applied, thanks. On Fri, Apr 25, 2014 at 3:36 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: Call ref_transaction_commit with QUIET_ON_ERR and use the error string that is returned to print a better log message if/after the transaction fails. Ah, so that's

[PATCH v3 05/19] update-ref.c: use the error string from _commit to print better message

2014-04-25 Thread Ronnie Sahlberg
Call ref_transaction_commit with QUIET_ON_ERR and use the error string that is returned to print a better log message if/after the transaction fails. Update the tests to reflect that the log message is now slightly different fatal: update_ref failed: Cannot lock the ref 'some ref' versus from

Re: [PATCH v3 05/19] update-ref.c: use the error string from _commit to print better message

2014-04-25 Thread Jonathan Nieder
Ronnie Sahlberg wrote: Call ref_transaction_commit with QUIET_ON_ERR and use the error string that is returned to print a better log message if/after the transaction fails. Ah, so that's how the transition to a better API happens. Makes sense. (A mention of QUIET_ON_ERR in the patch that