Hi Michael:
> On 08/04/2014 03:13 AM, Duy Nguyen wrote:
>
>> On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen <[hidden email]>
>> wrote:
>> [...]
>>> My first impression reading this patch was to rename
>>> clear_filename() into free_and_clear_filename() or better
>>> free_filename(),
>>>
On 08/04/2014 03:13 AM, Duy Nguyen wrote:
> On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen wrote:
> [...]
>> My first impression reading this patch was to rename
>> clear_filename() into free_and_clear_filename() or better free_filename(),
>> but I never pressed the send button ;-)
>>
>> Rea
Duy Nguyen writes:
> I didn't realize Mike is making a lot more changes in lockfile.c, part
> of that is converting lk->filename to use strbuf [1]. Perhaps I should
> just withdraw this series, wait until Mike's series is merged, then
> redo 3/3 on top. Or Mike could just take 3/3 in as part of h
On Sun, Aug 3, 2014 at 1:13 AM, Torsten Bögershausen wrote:
> On 08/01/2014 07:55 PM, Junio C Hamano wrote:
>>
>> Junio C Hamano writes:
>>
>>> Nguyễn Thái Ngọc Duy writes:
>>>
Signed-off-by: Nguyễn Thái Ngọc Duy
>>>
>>> Somewhat underexplained, given that it seems to add some new
>>> sem
On 08/01/2014 07:55 PM, Junio C Hamano wrote:
Junio C Hamano writes:
Nguyễn Thái Ngọc Duy writes:
Signed-off-by: Nguyễn Thái Ngọc Duy
Somewhat underexplained, given that it seems to add some new
semantics.
+static void clear_filename(struct lock_file *lk)
+{
+ free(lk->filename);
Junio C Hamano writes:
> Nguyễn Thái Ngọc Duy writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy
>
> Somewhat underexplained, given that it seems to add some new
> semantics.
>
>> +static void clear_filename(struct lock_file *lk)
>> +{
>> +free(lk->filename);
>> +lk->filename = NULL;
>>
Nguyễn Thái Ngọc Duy writes:
> diff --git a/lockfile.c b/lockfile.c
> index 8fbcb6a..968b28f 100644
> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -7,13 +7,19 @@
> static struct lock_file *lock_file_list;
> static const char *alternate_index_output;
>
> +static void clear_filename(struct lock_fi
Nguyễn Thái Ngọc Duy writes:
> Signed-off-by: Nguyễn Thái Ngọc Duy
Somewhat underexplained, given that it seems to add some new
semantics.
> +static void clear_filename(struct lock_file *lk)
> +{
> + free(lk->filename);
> + lk->filename = NULL;
> +}
It is good to abstract out lk->fil
Signed-off-by: Nguyễn Thái Ngọc Duy
---
cache.h| 2 +-
lockfile.c | 56
2 files changed, 33 insertions(+), 25 deletions(-)
diff --git a/cache.h b/cache.h
index cc46be4..0d8dce7 100644
--- a/cache.h
+++ b/cache.h
@@ -539,7 +539,7 @@ st
9 matches
Mail list logo
