Re: [PATCH v3 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-27 Thread Jeff King
On Tue, Sep 27, 2016 at 11:23:24AM -0400, David Turner wrote: > +test_expect_success 'malformed mode in tree' ' > + hex_sha1=$(echo foo | git hash-object --stdin -w) && > + bin_sha1=$(echo $hex_sha1 | perl -ne "printf \"%03o\", ord for > /../g") && Sorry, the perl snippet I posted

Re: [PATCH v3 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-27 Thread Junio C Hamano
David Turner writes: > From: Jeff King > > When the tree-walker runs into an error, it just calls > die(), and the message is always "corrupt tree file". > However, we are actually covering several cases here; let's > give the user a hint about what

[PATCH v3 1/3] tree-walk: be more specific about corrupt tree errors

2016-09-27 Thread David Turner
From: Jeff King When the tree-walker runs into an error, it just calls die(), and the message is always "corrupt tree file". However, we are actually covering several cases here; let's give the user a hint about what happened. Let's also avoid using the word "corrupt", which