Re: [PATCH v3 1/6] t6300 (for-each-ref): clearly demarcate setup

2013-11-16 Thread Eric Sunshine 
On Fri, Nov 15, 2013 at 5:59 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
 Condense the two-step setup into one step, and give it an appropriate
 name.

 Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
 ---
  t/t6300-for-each-ref.sh | 5 +
  1 file changed, 1 insertion(+), 4 deletions(-)

 diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
 index 752f5cb..72d282f 100755
 --- a/t/t6300-for-each-ref.sh
 +++ b/t/t6300-for-each-ref.sh
 @@ -18,16 +18,13 @@ setdate_and_increment () {
  export GIT_COMMITTER_DATE GIT_AUTHOR_DATE
  }

 -test_expect_success 'Create sample commit with known timestamp' '
 +test_expect_success setup '
 setdate_and_increment 
 echo Using $datestamp  one 
 git add one 
 git commit -m Initial 
 setdate_and_increment 
 git tag -a -m Tagging at $datestamp testtag

Broken -chain here after these functions are combined.

 -'
 -
 -test_expect_success 'Create upstream config' '
 git update-ref refs/remotes/origin/master master 
 git remote add origin nowhere 
 git config branch.master.remote origin 
 --
 1.8.5.rc0.6.gfd75b41
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/6] t6300 (for-each-ref): clearly demarcate setup

2013-11-15 Thread Ramkumar Ramachandra 
Condense the two-step setup into one step, and give it an appropriate
name.

Signed-off-by: Ramkumar Ramachandra artag...@gmail.com
---
 t/t6300-for-each-ref.sh | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
index 752f5cb..72d282f 100755
--- a/t/t6300-for-each-ref.sh
+++ b/t/t6300-for-each-ref.sh
@@ -18,16 +18,13 @@ setdate_and_increment () {
 export GIT_COMMITTER_DATE GIT_AUTHOR_DATE
 }
 
-test_expect_success 'Create sample commit with known timestamp' '
+test_expect_success setup '
setdate_and_increment 
echo Using $datestamp  one 
git add one 
git commit -m Initial 
setdate_and_increment 
git tag -a -m Tagging at $datestamp testtag
-'
-
-test_expect_success 'Create upstream config' '
git update-ref refs/remotes/origin/master master 
git remote add origin nowhere 
git config branch.master.remote origin 
-- 
1.8.5.rc0.6.gfd75b41

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html