Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh

2012-07-24 Thread Jonathan Nieder
Jiang Xin wrote: > Since we have additional shell wrappers (gettextln and eval_gettextln) > for gettext, we need to take into account these wrappers when run > 'make pot' to extract messages from shell scripts. Yes, thanks for fixing it. As Stefano mentioned, s/run/running/ would make the above

Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh

2012-07-24 Thread Stefano Lattarini
On 07/24/2012 08:59 AM, Jiang Xin wrote: > Since we have additional shell wrappers (gettextln and eval_gettextln) > for gettext, we need to take into account these wrappers when run > s/when run/when running/ or s/when we run/. Sorry for not spotting that in my first review! > 'make pot' to extra

[PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh

2012-07-24 Thread Jiang Xin
Since we have additional shell wrappers (gettextln and eval_gettextln) for gettext, we need to take into account these wrappers when run 'make pot' to extract messages from shell scripts. Signed-off-by: Jiang Xin Reviewed-by: Stefano Lattarini --- Makefile | 3 ++- 1 file changed, 2 insertions(