[PATCH v3 13/31] rm: convert to use parse_pathspec

[Nguyễn Thái Ngọc Duy]

Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
---
 builtin/rm.c | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/builtin/rm.c b/builtin/rm.c
index dabfcf6..1a2c932 100644
--- a/builtin/rm.c
+++ b/builtin/rm.c
@@ -216,7 +216,7 @@ static struct option builtin_rm_options[] = {
 int cmd_rm(int argc, const char **argv, const char *prefix)
 {
        int i, newfd;
-       const char **pathspec;
+       struct pathspec pathspec;
        char *seen;
 
        git_config(git_default_config, NULL);
@@ -249,31 +249,30 @@ int cmd_rm(int argc, const char **argv, const char 
*prefix)
                }
        }
 
-       pathspec = get_pathspec(prefix, argv);
-       refresh_index(&the_index, REFRESH_QUIET, pathspec, NULL, NULL);
+       parse_pathspec(&pathspec, PATHSPEC_FROMTOP, 0, prefix, argv);
+       refresh_index(&the_index, REFRESH_QUIET, pathspec.raw, NULL, NULL);
 
        seen = NULL;
-       for (i = 0; pathspec[i] ; i++)
-               /* nothing */;
-       seen = xcalloc(i, 1);
+       seen = xcalloc(pathspec.nr, 1);
 
        for (i = 0; i < active_nr; i++) {
                struct cache_entry *ce = active_cache[i];
-               if (!match_pathspec(pathspec, ce->name, ce_namelen(ce), 0, 
seen))
+               if (!match_pathspec_depth(&pathspec, ce->name, ce_namelen(ce), 
0, seen))
                        continue;
                ALLOC_GROW(list.entry, list.nr + 1, list.alloc);
                list.entry[list.nr].name = ce->name;
                list.entry[list.nr++].is_submodule = S_ISGITLINK(ce->ce_mode);
        }
 
-       if (pathspec) {
-               const char *match;
+       if (pathspec.nr) {
+               const char *original;
                int seen_any = 0;
-               for (i = 0; (match = pathspec[i]) != NULL ; i++) {
+               for (i = 0; i < pathspec.nr; i++) {
+                       original = pathspec.items[i].original;
                        if (!seen[i]) {
                                if (!ignore_unmatch) {
                                        die(_("pathspec '%s' did not match any 
files"),
-                                           match);
+                                           original);
                                }
                        }
                        else {
@@ -281,7 +280,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
                        }
                        if (!recursive && seen[i] == MATCHED_RECURSIVELY)
                                die(_("not removing '%s' recursively without 
-r"),
-                                   *match ? match : ".");
+                                   *original ? original : ".");
                }
 
                if (! seen_any)
-- 
1.8.0.rc2.23.g1fb49df

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html