Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-04-03 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > So I think I prefer using an option and not a heuristic if you > are fine with that. Sure. Changing behaviour only by explicit user request (command line or configuration) is much safer than heuristics that does not work reliably. -- To unsubscribe from this list:

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-04-02 Thread Michael S. Tsirkin
On Wed, Apr 02, 2014 at 11:18:26AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Mar 31, 2014 at 12:54:46PM -0700, Junio C Hamano wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > The hash used is mostly an internal implementation detail, isn't it? > >> > >> Yes,

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-04-02 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > On Mon, Mar 31, 2014 at 12:54:46PM -0700, Junio C Hamano wrote: >> "Michael S. Tsirkin" writes: >> >> > The hash used is mostly an internal implementation detail, isn't it? >> >> Yes, but that does not mean we can break people who keep an external >> database ind

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-03-31 Thread Michael S. Tsirkin
On Mon, Mar 31, 2014 at 12:54:46PM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > The hash used is mostly an internal implementation detail, isn't it? > > Yes, but that does not mean we can break people who keep an external > database indexed with the patch-id by changing the

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-03-31 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > The hash used is mostly an internal implementation detail, isn't it? Yes, but that does not mean we can break people who keep an external database indexed with the patch-id by changing the default under them, and "they can give --unstable option to work it around"

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-03-31 Thread Michael S. Tsirkin
On Mon, Mar 31, 2014 at 12:08:36PM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > Clarify that patch ID is now a sum of hashes, not a hash. > > Document --stable and --unstable flags. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > changes from v2: > > explicitly

Re: [PATCH v3 2/3] patch-id: document new behaviour

2014-03-31 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > Clarify that patch ID is now a sum of hashes, not a hash. > Document --stable and --unstable flags. > > Signed-off-by: Michael S. Tsirkin > --- > > changes from v2: > explicitly list the kinds of changes against which patch ID is stable > > Documentation/git

[PATCH v3 2/3] patch-id: document new behaviour

2014-03-30 Thread Michael S. Tsirkin
Clarify that patch ID is now a sum of hashes, not a hash. Document --stable and --unstable flags. Signed-off-by: Michael S. Tsirkin --- changes from v2: explicitly list the kinds of changes against which patch ID is stable Documentation/git-patch-id.txt | 23 ++- 1