Re: [PATCH v3 2/6] sha1_file.c: do not die failing to malloc in unpack_compressed_entry

2014-08-13 Thread Junio C Hamano
Looks very sensible. Thanks. On Wed, Aug 13, 2014 at 3:57 AM, Nguyễn Thái Ngọc Duy wrote: > Fewer die() gives better control to the caller, provided that the > caller _can_ handle it. And in unpack_compressed_entry() case, it can, > because unpack_compressed_entry() already returns NULL if it fai

[PATCH v3 2/6] sha1_file.c: do not die failing to malloc in unpack_compressed_entry

2014-08-13 Thread Nguyễn Thái Ngọc Duy
Fewer die() gives better control to the caller, provided that the caller _can_ handle it. And in unpack_compressed_entry() case, it can, because unpack_compressed_entry() already returns NULL if it fails to inflate data. A side effect from this is fsck continues to run when very large blobs are pr