Re: [PATCH v3 21/25] checkout: support checking out into a new working directory

2014-02-26 Thread Eric Sunshine
On Wed, Feb 26, 2014 at 6:19 PM, Duy Nguyen wrote: > On Thu, Feb 27, 2014 at 3:06 AM, Eric Sunshine > wrote: >>> + len = strlen(path); >>> + if (!len || is_dir_sep(path[len - 1])) >>> + die(_("'--to' argument '%s' cannot end with a slash"), >>> path); >> >> What is the

Re: [PATCH v3 21/25] checkout: support checking out into a new working directory

2014-02-26 Thread Duy Nguyen
On Thu, Feb 27, 2014 at 3:06 AM, Eric Sunshine wrote: >> + len = strlen(path); >> + if (!len || is_dir_sep(path[len - 1])) >> + die(_("'--to' argument '%s' cannot end with a slash"), path); > > What is the purpose of this restriction? Laziness on my part :) Because the f

Re: [PATCH v3 21/25] checkout: support checking out into a new working directory

2014-02-26 Thread Eric Sunshine
On Tue, Feb 18, 2014 at 8:40 AM, Nguyễn Thái Ngọc Duy wrote: > "git checkout --to" sets up a new working directory with a .git file > pointing to $GIT_DIR/repos/. It then executes "git checkout" again > on the new worktree with the same arguments except "--to" is taken > out. The second checkout e

[PATCH v3 21/25] checkout: support checking out into a new working directory

2014-02-18 Thread Nguyễn Thái Ngọc Duy
"git checkout --to" sets up a new working directory with a .git file pointing to $GIT_DIR/repos/. It then executes "git checkout" again on the new worktree with the same arguments except "--to" is taken out. The second checkout execution, which is not contaminated with any info from the current rep