Re: [PATCH v3 3/7] completion: add new __gitcompadd helper

2013-04-12 Thread Junio C Hamano
Felipe Contreras writes: > On Fri, Apr 12, 2013 at 12:55 PM, Junio C Hamano wrote: >> Felipe Contreras writes: > >>> } >>> >>> # Generates completion reply with compgen from newline-separated possible >>> @@ -1820,7 +1823,7 @@ _git_config () >>> local remote="${prev#remote.}" >>

Re: [PATCH v3 3/7] completion: add new __gitcompadd helper

2013-04-12 Thread Felipe Contreras
On Fri, Apr 12, 2013 at 12:55 PM, Junio C Hamano wrote: > Felipe Contreras writes: >> } >> >> # Generates completion reply with compgen from newline-separated possible >> @@ -1820,7 +1823,7 @@ _git_config () >> local remote="${prev#remote.}" >> remote="${remote%.fet

Re: [PATCH v3 3/7] completion: add new __gitcompadd helper

2013-04-12 Thread Junio C Hamano
Felipe Contreras writes: > The idea is to never touch the COMPREPLY variable directly. > > This allows other completion systems (i.e. zsh) to override > __gitcompadd, and do something different instead. > > Also, this allows further optimizations down the line. > > There should be no functional c

[PATCH v3 3/7] completion: add new __gitcompadd helper

2013-04-09 Thread Felipe Contreras
The idea is to never touch the COMPREPLY variable directly. This allows other completion systems (i.e. zsh) to override __gitcompadd, and do something different instead. Also, this allows further optimizations down the line. There should be no functional changes. Signed-off-by: Felipe Contreras