Re: [PATCH v3 4/6] trailer: make args have their own struct

2016-10-18 Thread Junio C Hamano
Stefan Beller writes: >> @@ -29,6 +29,12 @@ struct trailer_item { >> struct list_head list; >> char *token; >> char *value; >> +}; >> + >> +struct arg_item { >> + struct list_head list; >> + char *token; >> + char *value; >>

Re: [PATCH v3 4/6] trailer: make args have their own struct

2016-10-17 Thread Stefan Beller
On Fri, Oct 14, 2016 at 10:38 AM, Jonathan Tan wrote: > Improve type safety by making arguments (whether from configuration or > from the command line) have their own "struct arg_item" type, separate > from the "struct trailer_item" type used to represent the trailers in

[PATCH v3 4/6] trailer: make args have their own struct

2016-10-14 Thread Jonathan Tan
Improve type safety by making arguments (whether from configuration or from the command line) have their own "struct arg_item" type, separate from the "struct trailer_item" type used to represent the trailers in the buffer being manipulated. This change also prepares "struct trailer_item" to be