Re: [PATCH v5 05/12] Integrate wildmatch to git

[Torsten Bögershausen]

diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
new file mode 100755
index 000..dbd3c8b
--- /dev/null
+++ b/t/t3070-wildmatch.sh
@@ -0,0 +1,188 @@
+#!/bin/sh
+#else
+#test_expect_success BROKEN_FNMATCH fnmatch:   '$3' '$4' 
+#! test-wildmatch fnmatch '$3' '$4'
+#
+fi
+}
+

Thanks:
On my Mac OS X box:
# passed all 259 test(s)

And a quick test on cygwin:
$ ./t3070-wildmatch.sh  21 | grep not ok
not ok - 148 fnmatch:  match '5' '[[:xdigit:]]'
not ok - 150 fnmatch:  match 'f' '[[:xdigit:]]'
not ok - 152 fnmatch:  match 'D' '[[:xdigit:]]'


And 2 micronits:
a) Commented out code
b) Whithespace damage
( 4 spaces used for an indent of 1, TAB for indent of 2)

/Torsten


--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 05/12] Integrate wildmatch to git

[Junio C Hamano]

Nguyễn Thái Ngọc Duy  pclo...@gmail.com writes:

 +++ b/t/t3070-wildmatch.sh
 @@ -0,0 +1,188 @@
 +#!/bin/sh
 +
 +test_description='wildmatch tests'
 +
 +. ./test-lib.sh
 +
 +match() {
 +if [ $1 = 1 ]; then
 + test_expect_success wildmatch:match '$3' '$4' 
 + test-wildmatch wildmatch '$3' '$4'
 + 
 +else
 + test_expect_success wildmatch: no match '$3' '$4' 
 + ! test-wildmatch wildmatch '$3' '$4'
 + 
 +fi
 +if [ $2 = 1 ]; then
 + test_expect_success fnmatch:  match '$3' '$4' 
 + test-wildmatch fnmatch '$3' '$4'
 + 
 +elif [ $2 = 0 ]; then
 + test_expect_success fnmatch:   no match '$3' '$4' 
 + ! test-wildmatch fnmatch '$3' '$4'
 + 
 +#else
 +#test_expect_success BROKEN_FNMATCH fnmatch:   '$3' '$4' 
 +#! test-wildmatch fnmatch '$3' '$4'
 +#
 +fi

Heh, broken can be two-way.  Either it may succeed matching what it
shouldn't, or it may not match what it should.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html