Ramkumar Ramachandra artag...@gmail.com writes:
A couple of quick nits.
Tanay Abhra wrote:
+test_expect_success 'clear default config' '
+ rm -f .git/config
+'
Unnecessary; a fresh temporary directory is created for each test run.
Hmm, fresh, but not empty.
Anyway, the next test
Expose the `config_set` C API as a set of simple commands in order to
facilitate testing. Add tests for the `config_set` API as well as for
`git_config_get_*()` family for the usual config files.
Signed-off-by: Tanay Abhra tanay...@gmail.com
---
.gitignore | 1 +
Makefile
Tanay Abhra tanay...@gmail.com writes:
+test_expect_success 'get value for a simple key' '
+ echo very blue expect
+ test-config get_value core.penguin actual
+ test_cmp expect actual
+'
All these tests would greatly benefit from a helper like
test_expect_config () {
Tanay Abhra tanay...@gmail.com writes:
diff --git a/test-config.c b/test-config.c
new file mode 100644
index 000..45ccd0a
--- /dev/null
+++ b/test-config.c
@@ -0,0 +1,127 @@
+#include cache.h
+#include hashmap.h
Useless include, you're not using the hashmap directly.
+int main(int
A couple of quick nits.
Tanay Abhra wrote:
+test_expect_success 'clear default config' '
+ rm -f .git/config
+'
Unnecessary; a fresh temporary directory is created for each test run.
+test_expect_success 'initialize default config' '
You might want to mark this as setup.
--
To
5 matches
Mail list logo
