Re: [PATCH v6 2/3] completion: add new __gitcompadd helper

2012-10-31 Thread SZEDER Gábor
On Wed, Oct 31, 2012 at 12:05:34AM +0100, Felipe Contreras wrote: > On Tue, Oct 30, 2012 at 11:58 PM, SZEDER Gábor wrote: > > On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote: > >> The idea is to never touch the COMPREPLY variable directly. > >> > >> This allows other completion sy

Re: [PATCH v6 2/3] completion: add new __gitcompadd helper

2012-10-30 Thread Felipe Contreras
On Tue, Oct 30, 2012 at 11:58 PM, SZEDER Gábor wrote: > On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote: >> The idea is to never touch the COMPREPLY variable directly. >> >> This allows other completion systems override __gitcompadd, and do >> something different instead. >> >> Al

Re: [PATCH v6 2/3] completion: add new __gitcompadd helper

2012-10-30 Thread SZEDER Gábor
On Mon, Oct 22, 2012 at 03:45:41AM +0200, Felipe Contreras wrote: > The idea is to never touch the COMPREPLY variable directly. > > This allows other completion systems override __gitcompadd, and do > something different instead. > > Also, this allows the simplification of the completion tests (s

[PATCH v6 2/3] completion: add new __gitcompadd helper

2012-10-21 Thread Felipe Contreras
The idea is to never touch the COMPREPLY variable directly. This allows other completion systems override __gitcompadd, and do something different instead. Also, this allows the simplification of the completion tests (separate patch). There should be no functional changes. Signed-off-by: Felipe