Re: [PATCH v7 0/3] some enhancements for reporting branch tracking info
2013/8/19 Junio C Hamano : > > I however feel that [1/3] is introducing a regression (what we used > to report, gone branches, are hidden), only to correct the > regression immediately after it with [2/3]. > > I wonder if these patches should be combined into one Yes, at least patch 1/3 and patch 2/3 can be squashed into one. > justification like "with the current code, a branch that is in sync > with its upstream, a branch whose upstream no longer exists and a > branch that does not build on anything else cannot be distinguished; > show the first class as 'same', mark the second class as 'gone', and For the first class, if there are differences between branch and its upstream, tracking info is displayed, but report nothing if they are identical. I do think report something in this case is useful. It may help me to find out which remote I am tracking, if there are several remotes for my repo. > show only the last one as 'not having any uptream', or something. I think keep silence in this case is better. -- Jiang Xin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/3] some enhancements for reporting branch tracking info
Jiang Xin writes: > Changes since v6: > > * s/broken/gone/ in [PATCH 2/3] (branch: mark missing tracking branch > as gone) > > * rewrite commit log for [PATCH 3/3] (status: always show tracking > branch even no change) > > Jiang Xin (3): > branch: not report invalid tracking branch > branch: mark missing tracking branch as gone > status: always show tracking branch even no change > > builtin/branch.c | 36 > remote.c | 72 +-- > t/t6040-tracking-info.sh | 89 > +--- > wt-status.c | 26 +++--- > 4 files changed, 175 insertions(+), 48 deletions(-) Thanks; getting clearer to read. I however feel that [1/3] is introducing a regression (what we used to report, gone branches, are hidden), only to correct the regression immediately after it with [2/3]. I wonder if these patches should be combined into one, with justification like "with the current code, a branch that is in sync with its upstream, a branch whose upstream no longer exists and a branch that does not build on anything else cannot be distinguished; show the first class as 'same', mark the second class as 'gone', and show only the last one as not having any uptream', or something. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v7 0/3] some enhancements for reporting branch tracking info
Changes since v6: * s/broken/gone/ in [PATCH 2/3] (branch: mark missing tracking branch as gone) * rewrite commit log for [PATCH 3/3] (status: always show tracking branch even no change) Jiang Xin (3): branch: not report invalid tracking branch branch: mark missing tracking branch as gone status: always show tracking branch even no change builtin/branch.c | 36 remote.c | 72 +-- t/t6040-tracking-info.sh | 89 +--- wt-status.c | 26 +++--- 4 files changed, 175 insertions(+), 48 deletions(-) -- 1.8.4.rc2.479.g44abce8 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
