[PATCH v8 0/4] tag: configure default tag sort via .gitconfig

2014-07-15 Thread Jacob Keller
This patch series is hopefully the final version of a series of patches which
updates git-tag to allow the .gitconfig variable 'tag.sort' to be used as the
default sort parameter. This version uses a new set/pop error routine setup
which enables correctly modifying the error routine to handle the config vs the
command line.

In addition, I split the patch such that all the changes to the original
parse_opt_sort are shown, and the following patch which extracts this function
is just a function extraction with no changes, making it easier to review the
new changes. One other minor bug fix is included as well.

Jacob Keller (4):
  usage: make error functions a stack
  tag: fix --sort tests to use cat-\EOF format
  tag: update parsing to be more precise regarding errors
  tag: support configuring --sort via .gitconfig

 Documentation/config.txt  |  5 +++
 Documentation/git-tag.txt |  5 ++-
 builtin/tag.c | 97 ---
 git-compat-util.h |  1 +
 t/t7004-tag.sh| 76 +++--
 usage.c   | 29 --
 6 files changed, 167 insertions(+), 46 deletions(-)

-- 
2.0.1.475.g9b8d714

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v8 0/4] tag: configure default tag sort via .gitconfig

2014-07-15 Thread Junio C Hamano
Jacob Keller jacob.e.kel...@intel.com writes:

 This patch series is hopefully the final version of a series of patches which
 updates git-tag to allow the .gitconfig variable 'tag.sort' to be used as the
 default sort parameter. This version uses a new set/pop error routine setup
 which enables correctly modifying the error routine to handle the config vs 
 the
 command line.

 In addition, I split the patch such that all the changes to the original
 parse_opt_sort are shown, and the following patch which extracts this function
 is just a function extraction with no changes, making it easier to review the
 new changes. One other minor bug fix is included as well.

 Jacob Keller (4):
   usage: make error functions a stack
   tag: fix --sort tests to use cat-\EOF format
   tag: update parsing to be more precise regarding errors
   tag: support configuring --sort via .gitconfig

The first one looked somewhat tricky, but looked nice overall from a
cursory reading.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html