Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

2016-09-27 Thread Jakub Narębski
W dniu 27.09.2016 o 10:39, Jeff King pisze: > On Mon, Sep 26, 2016 at 09:21:10PM +0200, Lars Schneider wrote: > >> On 25 Sep 2016, at 13:26, Jakub Narębski wrote: >> >>> W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: From: Lars Schneider ... +static int packet_wri

Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

2016-09-27 Thread Jeff King
On Mon, Sep 26, 2016 at 09:21:10PM +0200, Lars Schneider wrote: > On 25 Sep 2016, at 13:26, Jakub Narębski wrote: > > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> From: Lars Schneider > >> ... > >> > >> +static int packet_write_gently(const int fd_out, const char *buf, siz

Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

2016-09-26 Thread Lars Schneider
On 25 Sep 2016, at 13:26, Jakub Narębski wrote: > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider >> ... >> >> +static int packet_write_gently(const int fd_out, const char *buf, size_t >> size) > > I'm not sure what naming convention the rest of Git uses, b

Re: [PATCH v8 06/11] pkt-line: add packet_write_gently()

2016-09-25 Thread Jakub Narębski
W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > From: Lars Schneider > > packet_write_fmt_gently() uses format_packet() which lets the caller > only send string data via "%s". That means it cannot be used for > arbitrary data that may contain NULs. > > Add packet_write_gently() whic

[PATCH v8 06/11] pkt-line: add packet_write_gently()

2016-09-20 Thread larsxschneider
From: Lars Schneider packet_write_fmt_gently() uses format_packet() which lets the caller only send string data via "%s". That means it cannot be used for arbitrary data that may contain NULs. Add packet_write_gently() which writes arbitrary data and does not die in case of an error. The functio