[PATCHv2] grep: use slash for path delimiter, not colon

2013-08-26 Thread Phil Hord
When a commit is grepped and matching filenames are printed, grep-objects creates the filename by prefixing the original cmdline argument to the matched path separated by a colon. Normally this forms a valid blob reference to the filename, like this: git grep -l foo HEAD

Re: [PATCHv2] grep: use slash for path delimiter, not colon

2013-08-26 Thread Jeff King
On Mon, Aug 26, 2013 at 10:46:12AM -0400, Phil Hord wrote: This version is a bit more deterministic and also adds a test. It accepts the expense of examining the path argument again to determine if it is a tree-ish + path rather than just a tree (commit). The get_sha1 call occurs one extra

Re: [PATCHv2] grep: use slash for path delimiter, not colon

2013-08-26 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Mon, Aug 26, 2013 at 03:28:26PM -0400, Jeff King wrote: Changing the object_array API would be hard, but I don't think we need to do it here. Can we simply stop using object_array to pass the list, and instead just have a custom list? I'll see how