Re: [RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-11 Thread Eric Sunshine
On Thu, Jul 11, 2013 at 2:45 AM, Antoine Pelisse wrote: > On Wed, Jul 10, 2013 at 9:03 PM, Eric Sunshine > wrote: >> +static void check_mailmap(struct string_list *mailmap, const char *contact) >> +{ >> + const char *name, *mail; >> + size_t namelen, maillen; >> + struct ident_

Re: [RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-10 Thread Antoine Pelisse
On Wed, Jul 10, 2013 at 9:03 PM, Eric Sunshine wrote: > +static void check_mailmap(struct string_list *mailmap, const char *contact) > +{ > + const char *name, *mail; > + size_t namelen, maillen; > + struct ident_split ident; > + char term = null_out ? '\0' : '\n'; > + > +

Re: [RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-10 Thread Duy Nguyen
On Thu, Jul 11, 2013 at 12:50 PM, Eric Sunshine wrote: >>> + maybe_flush_or_die(stdout, "contact to stdout"); >> >> On error this function will print >> >> write failure on 'contact to stdout' >> >> maybe maybe_flush_or_die(stdout, "write contact to stdout") or >> something? From i18n point

Re: [RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-10 Thread Eric Sunshine
On Wed, Jul 10, 2013 at 10:31 PM, Duy Nguyen wrote: > On Thu, Jul 11, 2013 at 2:03 AM, Eric Sunshine > wrote: >> +static const struct option check_mailmap_options[] = { >> + OPT_BOOLEAN(0, "stdin", &use_stdin, >> + N_("also read contacts from stdin")), >> + OPT_BOOL

Re: [RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-10 Thread Duy Nguyen
On Thu, Jul 11, 2013 at 2:03 AM, Eric Sunshine wrote: > +static const struct option check_mailmap_options[] = { > + OPT_BOOLEAN(0, "stdin", &use_stdin, > + N_("also read contacts from stdin")), > + OPT_BOOLEAN('z', NULL, &null_out, > + N_("null-termi

[RFC/PATCH 1/4] builtin: add git-check-mailmap command

2013-07-10 Thread Eric Sunshine
Introduce command check-mailmap, similar to check-attr and check-ignore, which allows direct testing of .mailmap configuration. As plumbing accessible to scripts and other porcelain, check-mailmap publishes the stable, well-tested .mailmap functionality employed by built-in Git commands. Conseque