Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-19 Thread Mark Levedahl
On 07/18/2013 07:32 PM, Junio C Hamano wrote: Mark Levedahl writes: Unlike the results on the fast Win7 laptop, the above show statistically significant slow down from the fast_lstat approach. I'm just not seeing a case for the special case handling, and of course Junio has already voted with

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Junio C Hamano
Mark Levedahl writes: > Unlike the results on the fast Win7 laptop, the above show > statistically significant slow down from the fast_lstat approach. I'm > just not seeing a case for the special case handling, and of course > Junio has already voted with his preference of removing the special >

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Mark Levedahl
On 07/18/2013 05:49 PM, Torsten Bögershausen wrote: On 2013-07-18 19.50, Ramsay Jones wrote: Hmm, that looks good. :-D Torsten reported a performance boost using the win32 stat() implementation on a linux git repo (2s -> 1s, if I recall correctly) on cygwin 1.7. Do you have a larger repo avail

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Torsten Bögershausen
On 2013-07-18 19.50, Ramsay Jones wrote: > Mark Levedahl wrote: >> On 07/15/2013 10:06 PM, Torsten Bögershausen wrote: >>> On 2013-07-15 21.49, Junio C Hamano wrote: Mark Levedahl writes: >> In order to limit the adverse effects caused by this implementation, >> we provide a new

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Ramsay Jones
Mark Levedahl wrote: > On 07/15/2013 10:06 PM, Torsten Bögershausen wrote: >> On 2013-07-15 21.49, Junio C Hamano wrote: >>> Mark Levedahl writes: >>> > In order to limit the adverse effects caused by this implementation, > we provide a new "fast stat" interface, which allows us to use thi

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-18 Thread Junio C Hamano
Mark Levedahl writes: > Cygwin 1.7 is very different than the earlier, no longer supported, > and no longer available Cygwin variants in many ways, but stat is one > of them. Cygwin 1.7 uses Windows ACLs to represent file permissions, > and therefore gets the file permissions directly from the un

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-16 Thread Mark Levedahl
On 07/16/2013 05:36 PM, Ramsay Jones wrote: Caveats: 1) I don't find any speed improvement of the current patch over the previous one (the tests actually ran faster with the earlier patch, though the difference was less than 1%). 2) I still question this whole approach, especially having this non

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-16 Thread Mark Levedahl
On 07/16/2013 11:42 AM, Dmitry Potapov wrote: On Tue, Jul 16, 2013 at 7:54 AM, Mark Levedahl wrote: I see no difference in the above. (Yes, I checked multiple times that I was using different executables). Are you sure that you set core.filemode to false before testing? yes. -- To unsubscri

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-16 Thread Ramsay Jones
Mark Levedahl wrote: > On 07/10/2013 04:23 PM, Ramsay Jones wrote: >> Commit adbc0b6b ("cygwin: Use native Win32 API for stat", 30-09-2008) >> added a Win32 specific implementation of the stat functions. In order >> to handle absolute paths, cygwin mount points and symbolic links, this >> implement

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-16 Thread Dmitry Potapov
On Tue, Jul 16, 2013 at 7:54 AM, Mark Levedahl wrote: > > I see no difference in the above. (Yes, I checked multiple times that I was > using different executables). Are you sure that you set core.filemode to false before testing? If you have core.filemode set to true then you _always_ use Cygwi

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-15 Thread Mark Levedahl
On 07/15/2013 10:06 PM, Torsten Bögershausen wrote: On 2013-07-15 21.49, Junio C Hamano wrote: Mark Levedahl writes: In order to limit the adverse effects caused by this implementation, we provide a new "fast stat" interface, which allows us to use this only for interactions with the index (i

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-15 Thread Mark Levedahl
On 07/15/2013 03:49 PM, Junio C Hamano wrote: Mark Levedahl writes: In order to limit the adverse effects caused by this implementation, we provide a new "fast stat" interface, which allows us to use this only for interactions with the index (i.e. the cached stat data). Signed-off-by: Ramsay

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-15 Thread Torsten Bögershausen
On 2013-07-15 21.49, Junio C Hamano wrote: > Mark Levedahl writes: > >>> In order to limit the adverse effects caused by this implementation, >>> we provide a new "fast stat" interface, which allows us to use this >>> only for interactions with the index (i.e. the cached stat data). >>> >>> Signe

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-15 Thread Junio C Hamano
Mark Levedahl writes: >> In order to limit the adverse effects caused by this implementation, >> we provide a new "fast stat" interface, which allows us to use this >> only for interactions with the index (i.e. the cached stat data). >> >> Signed-off-by: Ramsay Jones >> --- > > I've tested this

Re: [RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-14 Thread Mark Levedahl
On 07/10/2013 04:23 PM, Ramsay Jones wrote: Commit adbc0b6b ("cygwin: Use native Win32 API for stat", 30-09-2008) added a Win32 specific implementation of the stat functions. In order to handle absolute paths, cygwin mount points and symbolic links, this implementation may fall back on the standa

[RFC/PATCH v2 1/1] cygwin: Add fast_lstat() and fast_fstat() functions

2013-07-10 Thread Ramsay Jones
Commit adbc0b6b ("cygwin: Use native Win32 API for stat", 30-09-2008) added a Win32 specific implementation of the stat functions. In order to handle absolute paths, cygwin mount points and symbolic links, this implementation may fall back on the standard cygwin l/stat() functions. Also, the choic