Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-30 Thread brian m. carlson
On Wed, Aug 28, 2013 at 04:18:03PM -0400, Jeff King wrote: > On Wed, Aug 28, 2013 at 01:05:38PM -0700, Junio C Hamano wrote: > > > What are our plans to help existing scripts people have written over > > time, especially before "status -s" was invented, that will be > > broken by use of this? > >

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Matthieu Moy
David Aguilar writes: > I have a poor imagination and cannot imagine why it needs to be > switchable. I could not either, but I found the reason in the commit message: eff80a9fd990 Some users do want to write a line that begin with a pound sign, #, in their commit log message. Many tra

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Matthieu Moy
Jonathan Nieder writes: > Matthieu Moy wrote: > >>In the long run, if users >> like the non-prefix output, it may make sense to flip the default value >> to true. > > Hmm, do you mean that the configuration is to give the change-averse > some time t

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Jonathan Nieder
Matthieu Moy wrote: > Historically, "git status" needed to prefix each output line with '#' so > that the output could be added as comment to the commit message. This > prefix comment has no real purpose when "git status" is ran from the > command-line, and this may distract users from the real co

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
David Aguilar writes: > On Wed, Aug 28, 2013 at 2:39 PM, Junio C Hamano wrote: >> Jeff King writes: >> >>> On Wed, Aug 28, 2013 at 01:05:38PM -0700, Junio C Hamano wrote: >>> What are our plans to help existing scripts people have written over time, especially before "status -s" was i

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread David Aguilar
On Wed, Aug 28, 2013 at 2:39 PM, Junio C Hamano wrote: > Jeff King writes: > >> On Wed, Aug 28, 2013 at 01:05:38PM -0700, Junio C Hamano wrote: >> >>> What are our plans to help existing scripts people have written over >>> time, especially before "status -s" was invented, that will be >>> broken

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> Matthieu Moy writes: >> >>> diff --git a/Documentation/config.txt b/Documentation/config.txt >>> index ec57a15..dacf4b9 100644 >>> --- a/Documentation/config.txt >>> +++ b/Documentation/config.txt >>> @@ -2118,6 +2118,11 @@ status.branch:: >>>

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
Matthieu Moy writes: > diff --git a/wt-status.c b/wt-status.c > index cb24f1f..97068d5 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -774,12 +778,21 @@ static void wt_status_print_tracking(struct wt_status > *s) > if (!format_tracking_info(branch, &sb)) > return; > >

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
Jeff King writes: > On Wed, Aug 28, 2013 at 01:05:38PM -0700, Junio C Hamano wrote: > >> What are our plans to help existing scripts people have written over >> time, especially before "status -s" was invented, that will be >> broken by use of this? > > I thought that our response to parsing the

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> diff --git a/Documentation/config.txt b/Documentation/config.txt >> index ec57a15..dacf4b9 100644 >> --- a/Documentation/config.txt >> +++ b/Documentation/config.txt >> @@ -2118,6 +2118,11 @@ status.branch:: >> Set to true to enable --branc

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Jeff King
On Wed, Aug 28, 2013 at 01:05:38PM -0700, Junio C Hamano wrote: > What are our plans to help existing scripts people have written over > time, especially before "status -s" was invented, that will be > broken by use of this? I thought that our response to parsing the long output of "git status" w

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
Junio C Hamano writes: > "status.omitCommentPrefix" that defaults to false might be a better > setting, I suspect. Or status.showCommentPrefix that defaults to true; I didn't mean to say a setting that defaults to false is preferred over one that defaults to true in my message. -- To unsubscribe

Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Junio C Hamano
Matthieu Moy writes: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index ec57a15..dacf4b9 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -2118,6 +2118,11 @@ status.branch:: > Set to true to enable --branch by default in linkgit:git-statu

[RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #

2013-08-28 Thread Matthieu Moy
Historically, "git status" needed to prefix each output line with '#' so that the output could be added as comment to the commit message. This prefix comment has no real purpose when "git status" is ran from the command-line, and this may distract users from the real content. Allow the user to dis