Re: [RFH/PATCH 0/4] git http tests with apache 2.4
Jeff King p...@peff.net writes: Apache 2.4 recently shipped in Debian unstable, and I noticed that all of the git httpd tests stopped working. It turns out that some configuration directives have changed between 2.2 and 2.4, and the httpd server would not start at all. With this series, the tests run again (for me, at least). The IfVersion checks hopefully mean that there are no regressions for people running 2.2 and lower. However, the final patch is very unsatisfactory. We have to pick an MPM module to mention in the config, but we don't have any idea what's available. I suspect what I have provided will work on most Unix-ish systems. Under Windows, there is a totally different MPM. But I am not sure that our http tests run at all on Windows, as we seem to check in lib-httpd.sh for a Unix-ish apache module path. Thanks. I think the final one, while it may be unsatisfactory, is a reasonable (or least bad) compromise, at least for now. I do not think of a better way, without adding if you want customization, write a snippet to be included in the configuration used during the test, which feels way overkill. As far as I know, Apache does not have a try to load this module and fallback directive. We could perhaps look in the module directory and try to do something clever in the shell before starting Apache. Advice from Apache gurus is welcome. [1/4]: t/lib-httpd/apache.conf: do not use LockFile in apache = 2.4 [2/4]: t/lib-httpd/apache.conf: load extra auth modules in apache 2.4 [3/4]: t/lib-httpd/apache.conf: load compat access module in apache 2.4 [4/4]: t/lib-httpd/apache.conf: configure an MPM module for apache 2.4 -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFH/PATCH 0/4] git http tests with apache 2.4
On Fri, Jun 14, 2013 at 10:32:57AM -0700, Junio C Hamano wrote: However, the final patch is very unsatisfactory. We have to pick an MPM module to mention in the config, but we don't have any idea what's available. I suspect what I have provided will work on most Unix-ish systems. Under Windows, there is a totally different MPM. But I am not sure that our http tests run at all on Windows, as we seem to check in lib-httpd.sh for a Unix-ish apache module path. Thanks. I think the final one, while it may be unsatisfactory, is a reasonable (or least bad) compromise, at least for now. I do not think of a better way, without adding if you want customization, write a snippet to be included in the configuration used during the test, which feels way overkill. Yeah, we may have to go there. My feeling on it (and why I posted it as-is) is that it improves the situation for some people, and should be no worse for anyone else. Therefore people who are on 2.4 and are still broken after this series can speak up and show us the exact breakage and fix they need without us having to guess. -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFH/PATCH 0/4] git http tests with apache 2.4
Apache 2.4 recently shipped in Debian unstable, and I noticed that all of the git httpd tests stopped working. It turns out that some configuration directives have changed between 2.2 and 2.4, and the httpd server would not start at all. With this series, the tests run again (for me, at least). The IfVersion checks hopefully mean that there are no regressions for people running 2.2 and lower. However, the final patch is very unsatisfactory. We have to pick an MPM module to mention in the config, but we don't have any idea what's available. I suspect what I have provided will work on most Unix-ish systems. Under Windows, there is a totally different MPM. But I am not sure that our http tests run at all on Windows, as we seem to check in lib-httpd.sh for a Unix-ish apache module path. As far as I know, Apache does not have a try to load this module and fallback directive. We could perhaps look in the module directory and try to do something clever in the shell before starting Apache. Advice from Apache gurus is welcome. [1/4]: t/lib-httpd/apache.conf: do not use LockFile in apache = 2.4 [2/4]: t/lib-httpd/apache.conf: load extra auth modules in apache 2.4 [3/4]: t/lib-httpd/apache.conf: load compat access module in apache 2.4 [4/4]: t/lib-httpd/apache.conf: configure an MPM module for apache 2.4 -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
