Re: [patch] list shortlog items in commit order

2005-08-02 Thread Linus Torvalds


On Tue, 2 Aug 2005, Jeff Garzik wrote:
> 
>   I don't really care either way.

I suspect it's mostly the users, not the developers, who care. The core
developers already know what went in, and have git to see it, they don't 
look at the shortlog output. So I suspect it's more important to see if 
there's user feedback one way or the other..

Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [patch] list shortlog items in commit order

2005-08-02 Thread Jeff Garzik

Junio C Hamano wrote:

Nicolas Pitre <[EMAIL PROTECTED]> writes:



The current shortlog list is backward making it look odd.
This reverses it so things appear more logically.



Sorry, I do not know how the shortlog looked like in BK days,
but it would be nice to match that order.  I do not have
preference either way myself.

I'll let it simmer and let the list decide, but I think the
kernel folks care the most about this one, so I am asking the
original authors, Linus and Jeff, if they want to go for it, or
veto it.


  I don't really care either way.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [patch] list shortlog items in commit order

2005-08-02 Thread Nicolas Pitre
On Tue, 2 Aug 2005, Junio C Hamano wrote:

> Nicolas Pitre <[EMAIL PROTECTED]> writes:
> 
> > The current shortlog list is backward making it look odd.
> > This reverses it so things appear more logically.
> 
> Sorry, I do not know how the shortlog looked like in BK days,
> but it would be nice to match that order.

This is precisely why I made this patch: to make it look like the BK 
shortlog.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [patch] list shortlog items in commit order

2005-08-02 Thread Junio C Hamano
Nicolas Pitre <[EMAIL PROTECTED]> writes:

> The current shortlog list is backward making it look odd.
> This reverses it so things appear more logically.

Sorry, I do not know how the shortlog looked like in BK days,
but it would be nice to match that order.  I do not have
preference either way myself.

I'll let it simmer and let the list decide, but I think the
kernel folks care the most about this one, so I am asking the
original authors, Linus and Jeff, if they want to go for it, or
veto it.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch] list shortlog items in commit order

2005-08-02 Thread Nicolas Pitre

The current shortlog list is backward making it look odd.
This reverses it so things appear more logically.

Signed-off-by: Nicolas Pitre <[EMAIL PROTECTED]>

diff --git a/git-shortlog b/git-shortlog
--- a/git-shortlog
+++ b/git-shortlog
@@ -90,7 +90,7 @@ sub shortlog_output {
 
# output author's 1-line summaries
$obj = $map{$key};
-   foreach $desc (@$obj) {
+   foreach $desc (reverse @$obj) {
print "  $desc\n";
$n_output++;
}
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html