Adding 'Signed-off-by' to 'subtree add --squash' commits

2014-07-07 Thread Finucane, Stephen
Is it possible to sign off squashed commits created by the 'git subtree add 
... --squash' command?

I ask, because the Signed-off-by tag is a requirement for a project I work on, 
but I've been unable to achieve this. A thorough search of Google/StackOverflow 
reveals nothing.

Regards,

Stephen Finucane

PS: A visualisation. The issue is the second squash commit

  |\  Merge: 000 000
  | | Author: Stephen Finucane stephen.finuc...@intel.com
  | | Date:   Mon Jul 7 10:21:51 2014 +0100
  | |
  | | Add xxx as a git subtree
  | |
  | | - There is no problem with this commit.
  | |
  | | Signed-off-by: Stephen Finucane stephen.finuc...@intel.com
  | |
  | * commit 
  |   Author: Stephen Finucane stephen.finuc...@intel.com
  |   Date:   Mon Jul 7 10:21:51 2014 +0100
  |
  |   Squashed 'path/' content from commit 000
  |
  |   git-subtree-dir: path
  |   git-subtree-split: 
  |
  * commit 
  | Author: Stephen Finucane stephen.finuc...@intel.com
  | Date:   Mon Jul 7 10:04:38 2014 +0100
  ...
--
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole 
use of the intended recipient(s). Any review or distribution by others is 
strictly prohibited. If you are not the intended recipient, please contact the 
sender and delete all copies.


--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Adding 'Signed-off-by' to 'subtree add --squash' commits

2014-07-07 Thread Andreas Schwab
Finucane, Stephen stephen.finuc...@intel.com writes:

 Is it possible to sign off squashed commits created by the 'git subtree add 
 ... --squash' command?

If it isn't directly possible, you can always use git commit --amend -C
HEAD -s to modify the commit afterwards.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Adding 'Signed-off-by' to 'subtree add --squash' commits

2014-07-07 Thread Jeff King
On Mon, Jul 07, 2014 at 06:55:07PM +0200, Andreas Schwab wrote:

 Finucane, Stephen stephen.finuc...@intel.com writes:
 
  Is it possible to sign off squashed commits created by the 'git subtree 
  add ... --squash' command?
 
 If it isn't directly possible, you can always use git commit --amend -C
 HEAD -s to modify the commit afterwards.

I think that is sensible, though these days you can spell -C HEAD as
--no-edit, which I think is a bit more obvious.

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html