Re: Bug: commit -p breaks with -m

On Thu, Aug 15, 2013 at 10:28:16AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > Unfortunately, I think that will require some refactoring of the > > run_hook interface, which does not allow arbitrary environment > > parameters to be set. > > Heh, I said that long time ago, e.g. $gmane

Re: Bug: commit -p breaks with -m

Jeff King writes: > Unfortunately, I think that will require some refactoring of the > run_hook interface, which does not allow arbitrary environment > parameters to be set. Heh, I said that long time ago, e.g. $gmane/212284 ;-) This might turn out to be a good starting point, even though I did

Re: Bug: commit -p breaks with -m

On Thu, Aug 15, 2013 at 12:43:39AM -0400, Matan Nassau wrote: > With git 1.8.3.3, > > $ seq 5 >data > $ git add data > $ git commit -mdata > $ sed -i '2 d' data > $ git commit -pmchange > > At the prompt, type e to edit the hunk. The editor doesn't start, but > git records a commit. > > I

Bug: commit -p breaks with -m

With git 1.8.3.3, $ seq 5 >data $ git add data $ git commit -mdata $ sed -i '2 d' data $ git commit -pmchange At the prompt, type e to edit the hunk. The editor doesn't start, but git records a commit. I found that builtin/commit.c sets the GIT_EDITOR env var to ":" when the user specifie