Notes in format-patch (was: Re: [PATCHv3] replace: parse revision argument for -d)
Michael J Gruber venit, vidit, dixit 12.11.2012 15:18: 'git replace' parses the revision arguments when it creates replacements (so that a sha1 can be abbreviated, e.g.) but not when deleting replacements. Make it parse the argument to 'replace -d' in the same way. Signed-off-by: Michael J Gruber g...@drmicha.warpmail.net --- Notes: v3 safeguards the hex buffer against reuse builtin/replace.c | 16 ++-- t/t6050-replace.sh | 11 +++ 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/builtin/replace.c b/builtin/replace.c By the way - Junio, is that the intented outcome of format-patch --notes? I would rather put the newline between the note and the diffstat (and omit the one after the ---) but may have goofed up a rebase: ... Signed-off-by: Michael J Gruber g...@drmicha.warpmail.net --- Notes: v3 safeguards the hex buffer against reuse builtin/replace.c | 16 ++-- ... -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Notes in format-patch (was: Re: [PATCHv3] replace: parse revision argument for -d)
On Tue, Nov 13, 2012 at 11:30:19AM +0100, Michael J Gruber wrote: Michael J Gruber venit, vidit, dixit 12.11.2012 15:18: 'git replace' parses the revision arguments when it creates replacements (so that a sha1 can be abbreviated, e.g.) but not when deleting replacements. Make it parse the argument to 'replace -d' in the same way. Signed-off-by: Michael J Gruber g...@drmicha.warpmail.net --- Notes: v3 safeguards the hex buffer against reuse builtin/replace.c | 16 ++-- t/t6050-replace.sh | 11 +++ 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/builtin/replace.c b/builtin/replace.c By the way - Junio, is that the intented outcome of format-patch --notes? I would rather put the newline between the note and the diffstat (and omit the one after the ---) but may have goofed up a rebase: I do not know was intended, but the above quoted output is hard to read, and your suggested change looks way better. -Peff -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
