Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-18 Thread Karsten Blees
Am 10.12.2013 00:45, schrieb Jonathan Nieder: Karsten Blees wrote: Googling some more, I believe the most protable way to achieve this via 'compiler settings' is #pragma pack(push) #pragma pack(4) struct hashmap_entry { struct hashmap_entry *next; unsigned int hash; };

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-18 Thread Karsten Blees
Am 18.12.2013 14:10, schrieb Karsten Blees: + printf(sizeof(pointer+int) (%u) is not a +multiple of sizeof(pointer) (%u)!\n, +sizeof(struct pointer_int), +

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-18 Thread Karsten Blees
Am 09.12.2013 15:03, schrieb Karsten Blees: 3.) Inject individual fields via macro Instead of injecting a struct hashmap_entry, which implies alignment to sizeof(struct hashmap_entry), we could inject the individual fields, e.g. #define HASHMAP_ENTRY_HEADER struct hashmap_entry __next;

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Karsten Blees
Am 08.12.2013 11:20, schrieb Thomas Rast: Karsten Blees karsten.bl...@gmail.com writes: Am 07.12.2013 23:23, schrieb Thomas Rast: Karsten Blees karsten.bl...@gmail.com writes: Extending 'struct hashmap_entry' with an int-sized member shouldn't waste memory on 64-bit systems. This is

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Junio C Hamano
Karsten Blees karsten.bl...@gmail.com writes: Am 07.12.2013 00:52, schrieb Junio C Hamano: * kb/doc-exclude-directory-semantics (2013-11-07) 1 commit - gitignore.txt: clarify recursive nature of excluded directories Originally merged to 'next' on 2013-11-13 Kicked back to 'pu' to

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Junio C Hamano
Karsten Blees karsten.bl...@gmail.com writes: * kb/fast-hashmap (2013-11-18) 14 commits (merged to 'next' on 2013-12-06 at f90be3d) Damn, a day too late :-) I found these two glitches today...is a fixup patch OK or should I do a reroll (or separate patch on top)? A separate patch on top

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Jonathan Nieder
Karsten Blees wrote: GCC supports __packed__ as of 2.3 (1992), so any other compilers that copied the __attribute__ feature probably won't complain. Alas, it looks like HP C doesn't support __packed__ (not that I care much about HP C):

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Jeff King
On Sat, Dec 07, 2013 at 06:03:22PM +0100, Thomas Rast wrote: Junio C Hamano gits...@pobox.com writes: * jk/pack-bitmap (2013-11-18) 22 commits [...] Peff can decide if he wants to reroll with my nits or not; either way I'm all for moving it forward and aiming for one of the next releases.

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Karsten Blees
Am 09.12.2013 21:08, schrieb Jonathan Nieder: Karsten Blees wrote: GCC supports __packed__ as of 2.3 (1992), so any other compilers that copied the __attribute__ feature probably won't complain. Alas, it looks like HP C doesn't support __packed__ (not that I care much about HP C):

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-09 Thread Jonathan Nieder
Karsten Blees wrote: (Besides, __attribute__((aligned)) / __declspec(align) can only _increase_ the alignment, so aligned(1) would have no effect). Good catch. Googling some more, I believe the most protable way to achieve this via 'compiler settings' is #pragma pack(push) #pragma

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-08 Thread Thomas Rast
Karsten Blees karsten.bl...@gmail.com writes: Am 07.12.2013 23:23, schrieb Thomas Rast: Karsten Blees karsten.bl...@gmail.com writes: Extending 'struct hashmap_entry' with an int-sized member shouldn't waste memory on 64-bit systems. This is already documented in api-hashmap.txt, but needs

RE: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-07 Thread Felipe Contreras
Junio C Hamano wrote: * fc/transport-helper-fixes (2013-11-13) 12 commits - remote-bzr: support the new 'force' option - transport-helper: add support to delete branches - fast-export: add support to delete refs - fast-import: add support to delete refs - transport-helper: add support

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-07 Thread Karsten Blees
Am 07.12.2013 00:52, schrieb Junio C Hamano: * kb/doc-exclude-directory-semantics (2013-11-07) 1 commit - gitignore.txt: clarify recursive nature of excluded directories Originally merged to 'next' on 2013-11-13 Kicked back to 'pu' to replace with a newer reroll ($gmane/237814 looked

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-07 Thread Felipe Contreras
On Sat, Dec 7, 2013 at 4:03 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Junio C Hamano wrote: * fc/transport-helper-fixes (2013-11-13) 12 commits - remote-bzr: support the new 'force' option - transport-helper: add support to delete branches - fast-export: add support to delete

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-07 Thread Thomas Rast
Karsten Blees karsten.bl...@gmail.com writes: Extending 'struct hashmap_entry' with an int-sized member shouldn't waste memory on 64-bit systems. This is already documented in api-hashmap.txt, but needs '__attribute__((__packed__))' to work. Reduces e.g. You'd have to guard

Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)

2013-12-07 Thread Karsten Blees
Am 07.12.2013 23:23, schrieb Thomas Rast: Karsten Blees karsten.bl...@gmail.com writes: Extending 'struct hashmap_entry' with an int-sized member shouldn't waste memory on 64-bit systems. This is already documented in api-hashmap.txt, but needs '__attribute__((__packed__))' to work. Reduces