Re: What's cooking between #05 and #06
On Wed, Apr 17, 2013 at 11:25:07PM +0200, Jens Lehmann wrote: I like it, as it gets rid of the top-level requirement. But from my testing it looks like we're not quite there yet. 'summary' and 'status' behave as if they were run in the toplevel directory, while a git status shows all filenames relative to the current directory. Me thinks 'summary' and 'status' (and all other submodule commands) should behave like status and print relative paths too. I'm not really sure yet how $sm_path should behave for 'foreach', but I suspect having it relative to the current directory would be the way to go (which it currently isn't). When submodule add is run with a relative path it is relative to the top-level directory, which I find confusing (and won't play well with shell completion). This confused me for a bit because I was sure I handled this, but I see I missed relative submodules URLs. So the path at which to put the submodule is correct, but the path from which to clone is not. 'deinit .' doesn't deinit submodules above the current directory (but prints the path relative to top-level) while 'init' will initialize all submodules known to the superproject. I can't see how this happens. 'init' uses module_list which has been updated to handle relative paths. So I expect 'git submodule init .' to work correctly here. I would expect either of them to act on all submodules when given no extra arguments. So this is a good start, but it looks like there is some work left to do before this can hit master. Thanks for the feedback. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking between #05 and #06
On Tue, Apr 16, 2013 at 04:52:14PM -0700, Junio C Hamano wrote: * jk/remote-helper-with-signed-tags (2013-04-15) 3 commits - transport-helper: add 'signed-tags' capability - transport-helper: pass --signed-tags=warn-strip to fast-export - fast-export: add --signed-tags=warn-strip mode There were some comments on the noisiness of the warning output, but it appears that everybody involved in the area is basically happy with the direction this series goes in, so I'll expect a reroll and then merge it to 'next'. What do you expect to change in the reroll? The only comments I've seen have been about the warning output it seems to me that we've agreed to leave that as it is. Have I missed something? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking between #05 and #06
John Keeping j...@keeping.me.uk writes: On Tue, Apr 16, 2013 at 04:52:14PM -0700, Junio C Hamano wrote: * jk/remote-helper-with-signed-tags (2013-04-15) 3 commits - transport-helper: add 'signed-tags' capability - transport-helper: pass --signed-tags=warn-strip to fast-export - fast-export: add --signed-tags=warn-strip mode There were some comments on the noisiness of the warning output, but it appears that everybody involved in the area is basically happy with the direction this series goes in, so I'll expect a reroll and then merge it to 'next'. What do you expect to change in the reroll? The only comments I've seen have been about the warning output it seems to me that we've agreed to leave that as it is. Have I missed something? You missed the sender timestamp of the message you are responding to, and that of the discussion we later agreed there is nothing to change ;-) -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: What's cooking between #05 and #06
Am 17.04.2013 01:52, schrieb Junio C Hamano: * jk/submodule-subdirectory-ok (2013-04-10) 2 commits - submodule: drop the top-level requirement - rev-parse: add --prefix option Allow various subcommands of git submodule to be run not from the top of the working tree of the superproject. Waiting for comments. Any submodule users wants to weigh in? The code looked fine, but I do not heavily use it (and the repository with a submodule I have, I do not have a subdirectory ;-, so I am a bad guinea pig). I like it, as it gets rid of the top-level requirement. But from my testing it looks like we're not quite there yet. 'summary' and 'status' behave as if they were run in the toplevel directory, while a git status shows all filenames relative to the current directory. Me thinks 'summary' and 'status' (and all other submodule commands) should behave like status and print relative paths too. I'm not really sure yet how $sm_path should behave for 'foreach', but I suspect having it relative to the current directory would be the way to go (which it currently isn't). When submodule add is run with a relative path it is relative to the top-level directory, which I find confusing (and won't play well with shell completion). 'deinit .' doesn't deinit submodules above the current directory (but prints the path relative to top-level) while 'init' will initialize all submodules known to the superproject. So this is a good start, but it looks like there is some work left to do before this can hit master. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
