Re: [BUG REPORT] Git log pretty date

2014-06-03 Thread Dennis Kaarsemaker
On Mon, Jun 02, 2014 at 11:46:19PM -0400, Jeff King wrote: On Fri, May 30, 2014 at 09:08:57AM +0100, Rodrigo Fernandes wrote: Do you have any idea how does github understand that is a bug and fixes it automatically? (I'm saying this because on Github the date is correct). I looked into

Re: [BUG REPORT] Git log pretty date

2014-06-03 Thread Jeff King
On Tue, Jun 03, 2014 at 08:23:02AM +0200, Dennis Kaarsemaker wrote: On Mon, Jun 02, 2014 at 11:46:19PM -0400, Jeff King wrote: On Fri, May 30, 2014 at 09:08:57AM +0100, Rodrigo Fernandes wrote: Do you have any idea how does github understand that is a bug and fixes it automatically?

Re: [BUG REPORT] Git log pretty date

2014-06-02 Thread Jeff King
On Fri, May 30, 2014 at 09:08:57AM +0100, Rodrigo Fernandes wrote: Do you have any idea how does github understand that is a bug and fixes it automatically? (I'm saying this because on Github the date is correct). I looked into this. The dates you see on GitHub's web UI are actually parsed by

Re: [BUG REPORT] Git log pretty date

2014-05-30 Thread Rodrigo Fernandes
Jeff, Do you have any idea how does github understand that is a bug and fixes it automatically? (I'm saying this because on Github the date is correct). Cumprimentos, Rodrigo Fernandes On Thu, May 29, 2014 at 8:57 PM, Rodrigo Fernandes rtfrodr...@gmail.com wrote: Jeff, I have no idea what was

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Duy Nguyen
On Thu, May 29, 2014 at 5:29 PM, Rodrigo Fernandes rtfrodr...@gmail.com wrote: I get an empty response on the date field, but since pretty has `%ad` it should follow the --date and return the date even if wrong. ... I tried to check the source code but have no idea where to start, maybe if

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Dennis Kaarsemaker
On do, 2014-05-29 at 11:29 +0100, Rodrigo Fernandes wrote: The problem happens when I try to get a pretty log for a commit with a wrong date. The commit is: === $ git cat-file commit e9dddaf24c9de45d9b4efdf38eff7c30eb200f48 tree d63aeb159635cb231e191505a95a129a3b4a7b38 parent

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Rodrigo Fernandes
Dennis I think that could be an improvement. Duy, can you point me where is the date print from normal `git log` or `git show` so I can compare? On Thu, May 29, 2014 at 12:07 PM, Dennis Kaarsemaker den...@kaarsemaker.net wrote: On do, 2014-05-29 at 11:29 +0100, Rodrigo Fernandes wrote: The

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Duy Nguyen
On Thu, May 29, 2014 at 7:24 PM, Rodrigo Fernandes rtfrodr...@gmail.com wrote: Duy, can you point me where is the date print from normal `git log` or `git show` so I can compare? It's the same function, show_date() in date.c. -- Duy -- To unsubscribe from this list: send the line unsubscribe

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Jeff King
On Thu, May 29, 2014 at 05:50:56PM +0700, Duy Nguyen wrote: On Thu, May 29, 2014 at 5:29 PM, Rodrigo Fernandes rtfrodr...@gmail.com wrote: I get an empty response on the date field, but since pretty has `%ad` it should follow the --date and return the date even if wrong. ... I

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Junio C Hamano
Jeff King p...@peff.net writes: ... to at least make --format date output consistent with the rest of git (and to make %at consistent with %ad and --date=raw). That still doesn't address Rodrigo's concern, though (we would print 0 +). For that, we would want on top: 1. Teach

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Jeff King
On Thu, May 29, 2014 at 11:57:15AM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: ... to at least make --format date output consistent with the rest of git (and to make %at consistent with %ad and --date=raw). That still doesn't address Rodrigo's concern, though (we would

Re: [BUG REPORT] Git log pretty date

2014-05-29 Thread Rodrigo Fernandes
Jeff, I have no idea what was the tool. The repo is not mine. I found the problem when I was doing some tests and the commit parsing was failing on that repo. Cumprimentos, Rodrigo Fernandes On Thu, May 29, 2014 at 8:49 PM, Jeff King p...@peff.net wrote: On Thu, May 29, 2014 at 11:57:15AM