Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Jeff King
On Sun, Sep 09, 2012 at 12:24:58PM -0700, Junio C Hamano wrote: Having said all that, I am not sure if the fixing is really the right approach to begin with. Contrast these two: $ git blame MakeFILE $ git blame HEAD -- MakeFILE The latter, regardless of core.ignorecase, should

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: If the proposal were instead to add a certain type of pathspec that is case-insensitive[2], that would make much more sense to me. It is not violating git's case-sensitivity because it is purely a _query_ issue. And it is a feature you might use whether or not

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Jeff King
On Mon, Sep 10, 2012 at 01:30:03PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: If the proposal were instead to add a certain type of pathspec that is case-insensitive[2], that would make much more sense to me. It is not violating git's case-sensitivity because it is

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Mon, Sep 10, 2012 at 01:30:03PM -0700, Junio C Hamano wrote: Jeff King p...@peff.net writes: If the proposal were instead to add a certain type of pathspec that is case-insensitive[2], that would make much more sense to me. It is not violating git's

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Jeff King
On Mon, Sep 10, 2012 at 02:38:08PM -0700, Junio C Hamano wrote: Thanks, that helped. I got excited when I saw the icase in the comments and thought it might already be implemented. But it looks like it is still to be done. :) Yeah, some are tongue-in-cheek (e.g. I do not know what

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: But I would think for that particular use case, you would not want to do a per-glob prefix for that, but would rather use a command-line switch. Yes. Even though it is not listed as possible future semantics, one thing that we may want to have before all others

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-09 Thread Johannes Sixt
Am 09.09.2012 19:01, schrieb Ralf Thielow: If core.ignorecase is true, git blame fails when the given path differs to the real path in case sensitivity. ... + dir = opendir(res.buf); ... + struct dirent *ent = readdir(dir); ...

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-09 Thread Junio C Hamano
Ralf Thielow ralf.thie...@gmail.com writes: If core.ignorecase is true, git blame fails when the given path differs to the real path in case sensitivity. It is rather hard to respond to this request for comment because you are describing the behaviour you perceive as a problem only fuzzily

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-09 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: If we were to do anything, I would think the most sane thing to do is a smaller patch to fix fake_working_tree_commit() where it calls lstat() and _should_ die with Cannot lstat MakeFILE on a sane filesystem. It does not currently make sure the path

Re: [PATCH/RFC] blame: respect core.ignorecase

2012-09-09 Thread Ralf Thielow
On Sun, Sep 9, 2012 at 9:24 PM, Junio C Hamano gits...@pobox.com wrote: Ralf Thielow ralf.thie...@gmail.com writes: If core.ignorecase is true, git blame fails when the given path differs to the real path in case sensitivity. It is rather hard to respond to this request for comment because