Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin

[Junio C Hamano]

Mark Allen [EMAIL PROTECTED] writes:

 Looks good to me, Junio.  There's a very small typo in your
 commit though. :-)

Thanks.

-
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add $(LIBS) and set libiconv in tools/Makefile for Darwin

[Junio C Hamano]

Mark Allen [EMAIL PROTECTED] writes:

 This trivial patch creates $(LIBS) and sets it to iconv in
 tools/Makefile because MacOS 10.4 [gcc 4.0] gets cranky about
 libiconv routines referenced in mailinfo.c (convert_to_utf8)
 and no library pointer to link the symbols against.

I'd do this slightly differently.  Could you take a look at what
I have in the proposed updates branch, especially Flatten
tools/ directory commit?  What I am aiming for is to have
platform specific ifeq() thing in only one place.


-
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html