Re: [PATCH] Add grep.fullName config variable
Andreas Schwab writes: > Junio C Hamano writes: > >> Don't we have the exact same issue for the editor, by the way? >> Shouldn't we be running it in the original subdirectory as well? > > It's called with an absolute name, so it shouldn't care. But we should not have to call with absolute paths when a short and sweet pathname relative to the user's current directory. That is the primary point of my comment. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add grep.fullName config variable
Andreas Schwab writes: > Junio C Hamano writes: > >> Andreas Schwab writes: >> >>> This configuration variable sets the default for the --full-name option. >>> >>> Signed-off-by: Andreas Schwab >>> --- >> >> Would this change break Porcelains (e.g. Emacs modes) and force them >> to be updated to explicitly pass --no-full-name to unbreak them? > > Yes, that would be required. On the other hand, currently it is > impossible to cut-n-paste a file name without --full-name, since the > pager is always started in top-level. Perhaps it is better to fix the > latter? On the third hand, git grep isn't plumbing, so variation of output is to be expected? We already have grep.lineNumber and grep.patternType / grep.extendedRegexp (vc-git-grep uses -n itself, but does not protect against grep.patternType). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add grep.fullName config variable
Junio C Hamano writes: > Don't we have the exact same issue for the editor, by the way? > Shouldn't we be running it in the original subdirectory as well? It's called with an absolute name, so it shouldn't care. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add grep.fullName config variable
Andreas Schwab writes: > Yes, that would be required. On the other hand, currently it is > impossible to cut-n-paste a file name without --full-name, since the > pager is always started in top-level. Perhaps it is better to fix the > latter? So far we never cared where the pager runs, but as a principle, I think it would be nice if we run it in the original subdirectory, not at the top of the working tree (unless we have to bend backwards to make the codepath involved too ugly, that is). Don't we have the exact same issue for the editor, by the way? Shouldn't we be running it in the original subdirectory as well? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add grep.fullName config variable
Junio C Hamano writes: > Andreas Schwab writes: > >> This configuration variable sets the default for the --full-name option. >> >> Signed-off-by: Andreas Schwab >> --- > > Would this change break Porcelains (e.g. Emacs modes) and force them > to be updated to explicitly pass --no-full-name to unbreak them? Yes, that would be required. On the other hand, currently it is impossible to cut-n-paste a file name without --full-name, since the pager is always started in top-level. Perhaps it is better to fix the latter? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add grep.fullName config variable
Andreas Schwab writes:
> This configuration variable sets the default for the --full-name option.
>
> Signed-off-by: Andreas Schwab
> ---
Would this change break Porcelains (e.g. Emacs modes) and force them
to be updated to explicitly pass --no-full-name to unbreak them?
> Documentation/git-grep.txt | 3 +++
> grep.c | 5 +
> 2 files changed, 8 insertions(+)
>
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index f837334..31811f1 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -53,6 +53,9 @@ grep.extendedRegexp::
> option is ignored when the 'grep.patternType' option is set to a value
> other than 'default'.
>
> +grep.fullName::
> + If set to true, enable '--full-name' option by default.
> +
>
> OPTIONS
> ---
> diff --git a/grep.c b/grep.c
> index c668034..ece04bf 100644
> --- a/grep.c
> +++ b/grep.c
> @@ -86,6 +86,11 @@ int grep_config(const char *var, const char *value, void
> *cb)
> return 0;
> }
>
> + if (!strcmp(var, "grep.fullname")) {
> + opt->relative = !git_config_bool(var, value);
> + return 0;
> + }
> +
> if (!strcmp(var, "color.grep"))
> opt->color = git_config_colorbool(var, value);
> else if (!strcmp(var, "color.grep.context"))
> --
> 1.9.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
