Re* [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-21 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, Sep 19, 2012 at 01:31:50PM -0700, Kevin Ballard wrote: I am a little lukewarm on my patch if only because of the precedent it sets. There are a trillion options that revision.c parses that are not necessarily meaningful or implemented for

Re: Re* [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Let's do this for now instead. That would make it clear to people who (rightly or wrongly) think the --follow option should do something that we already do so, and explain the output that they see when they do give the --follow option to the command.

Re: [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-19 Thread Jeff King
On Tue, Sep 18, 2012 at 09:38:32PM -0700, Junio C Hamano wrote: That is a totally wrong message to send. You failed to teach the reader that there is no need to do anything special to tell the command to follow per-line origin across renames. So if anything, I would phrase it this way

Re: [PATCH] Documentation/git-blame.txt: --follow is a NO-OP

2012-09-18 Thread Junio C Hamano
Drew Northup n1xim.em...@gmail.com writes: Make note that while the --follow option is accepted by git blame it does nothing. Signed-off-by: Drew Northup n1xim.em...@gmail.com --- Documentation/git-blame.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git