Re: [PATCH] Documentation: filter-branch env-filter example

2013-02-14 Thread Junio C Hamano
Jeff King writes: > I think it has always been the case that we export them after setting > them; just look at the preimage from 3c730fab, and you can see exports > there. Yeah, I think the only difference is a broken commit case where sed expression did not find what it was looking for, in whic

Re: [PATCH] Documentation: filter-branch env-filter example

2013-02-14 Thread Jeff King
On Thu, Feb 14, 2013 at 04:09:10PM -0500, Jeff King wrote: > I think the advice in the documentation about re-exporting is because > some versions of the bourne shell will not reliably pass the new version > of the variable when you do this: > > VAR=old > export VAR > VAR=new > some_subpr

Re: [PATCH] Documentation: filter-branch env-filter example

2013-02-14 Thread Jeff King
On Thu, Feb 14, 2013 at 12:29:36PM -0800, Junio C Hamano wrote: > Quote the variable in double-quotes, like this: > > if [ "$GIT_AUTHOR_EMAIL" = j...@old.example.com ] > > Otherwise the comparison will break, if the e-mail part had a > whitespace in it, or if it were empty, which is an exa

Re: [PATCH] Documentation: filter-branch env-filter example

2013-02-14 Thread Junio C Hamano
Tadeusz Andrzej Kadłubowski writes: > filter-branch --env-filter example that shows how to change the email address > in all commits by a certain developer. > --- Thanks. Sign-off? > Documentation/git-filter-branch.txt | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/D

Re: [PATCH] Documentation: filter-branch env-filter example

2013-02-13 Thread Johannes Sixt
Am 2/13/2013 20:47, schrieb Tade: > filter-branch --env-filter example that shows how to change the email address > in all commits by a certain developer. > --- You should sign off your patch. Use a full real name, please. > Documentation/git-filter-branch.txt | 13 + > 1 file change