On Sat, Jul 20, 2013 at 10:53 PM, Junio C Hamano wrote:
> Actually, it is _wrong_ for us to rely on system header files to
> define this symbol for us. Declaring "extern char **environ" is
> responsibility of the user programs (like us).
Actually, that's right. The C99 standard doesn't mention
Torsten Bögershausen writes:
> On 2013-07-20 09.49, Benoit Sigoure wrote:
>> +#ifdef __APPLE__
>> +// On OS X libc headers don't define this symbol.
>> +extern char **environ;
>> +#endif
>> +
> A more generic approach could be:
>
> In the file "config.mak.uname": Define a variable in the Darwin s
On 2013-07-20 09.49, Benoit Sigoure wrote:
> +#ifdef __APPLE__
> +// On OS X libc headers don't define this symbol.
> +extern char **environ;
> +#endif
> +
A more generic approach could be:
In the file "config.mak.uname": Define a variable in the Darwin section like
this
NO_EXT_ENVIRON = Unfortun
On Sat, Jul 20, 2013 at 12:55 AM, Ramkumar Ramachandra
wrote:
> Benoit Sigoure wrote:
>> diff --git a/compat/unsetenv.c b/compat/unsetenv.c
>> index 4ea1856..addf3dc 100644
>> --- a/compat/unsetenv.c
>> +++ b/compat/unsetenv.c
>> @@ -1,5 +1,10 @@
>> #include "../git-compat-util.h"
>>
>> +#ifdef _
Benoit Sigoure wrote:
> diff --git a/compat/unsetenv.c b/compat/unsetenv.c
> index 4ea1856..addf3dc 100644
> --- a/compat/unsetenv.c
> +++ b/compat/unsetenv.c
> @@ -1,5 +1,10 @@
> #include "../git-compat-util.h"
>
> +#ifdef __APPLE__
> +// On OS X libc headers don't define this symbol.
> +extern c
5 matches
Mail list logo