Re: [PATCH] Fix git-p4 submit in non --prepare-p4-only mode

2014-06-11 Thread Maxime Coste
On Tue, Jun 10, 2014 at 06:39:58PM -0400, Pete Wyckoff wrote: frrr...@gmail.com wrote on Tue, 10 Jun 2014 13:14 +0100: b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here is a proper fix, including proper handling for windows end of lines. I guess we don't have test coverage

Re: [PATCH] Fix git-p4 submit in non --prepare-p4-only mode

2014-06-11 Thread Pete Wyckoff
frrr...@gmail.com wrote on Wed, 11 Jun 2014 14:06 +0100: On Tue, Jun 10, 2014 at 06:39:58PM -0400, Pete Wyckoff wrote: frrr...@gmail.com wrote on Tue, 10 Jun 2014 13:14 +0100: b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here is a proper fix, including proper handling for

Re: [PATCH] Fix git-p4 submit in non --prepare-p4-only mode

2014-06-10 Thread Pete Wyckoff
frrr...@gmail.com wrote on Tue, 10 Jun 2014 13:14 +0100: b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here is a proper fix, including proper handling for windows end of lines. I guess we don't have test coverage for these cases? Is this something that should get put into a