Re: [PATCH] Improve legibility of test_expect_code output
On Thu, Sep 20, 2012 at 6:45 PM, Junio C Hamano wrote: > Adam Spiers writes: >> On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote: >>> Do you want this queued on top of your other series, or as an >>> independent change? >> >> Independent please. > > With a sign-off? Yep. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
Adam Spiers writes: > On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote: >> Do you want this queued on top of your other series, or as an >> independent change? > > Independent please. With a sign-off? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
On Thu, Sep 20, 2012 at 5:50 PM, Junio C Hamano wrote: > Do you want this queued on top of your other series, or as an > independent change? Independent please. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
Adam Spiers writes: > On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> --- >> >> No explanation why this is a good idea, nor sign-off? > > I realised I forgot the sign-off seconds after sending :-( > > Isn't it completely self-explanatory? e.g. > > test_expect_code: command exited with 0, we wanted 128 git foo bar > > clearly makes more sense than > > test_expect_code: command exited with 0, we wanted 128 from: git foo bar test_expect_code: command exited with 0, we wanted 128: git foo bar would be shorter and equally legible, I would think. In any case, the proposed commit log message should have explained these differences in the first place so that I or others do not have to ask. Do you want this queued on top of your other series, or as an independent change? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
On Thu, Sep 20, 2012 at 1:35 AM, Junio C Hamano wrote: > If it were "..., we wanted 128 from 'git foo bar'", then I would, > but otherwise, not really. That's fine by me. Both are better than the status quo. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
Adam Spiers writes: > On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano wrote: >> Adam Spiers writes: >> >>> --- >> >> No explanation why this is a good idea, nor sign-off? > > I realised I forgot the sign-off seconds after sending :-( > > Isn't it completely self-explanatory? e.g. > > test_expect_code: command exited with 0, we wanted 128 git foo bar > > clearly makes more sense than > > test_expect_code: command exited with 0, we wanted 128 from: git foo bar If it were "..., we wanted 128 from 'git foo bar'", then I would, but otherwise, not really. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano wrote: > Adam Spiers writes: > >> --- > > No explanation why this is a good idea, nor sign-off? I realised I forgot the sign-off seconds after sending :-( Isn't it completely self-explanatory? e.g. test_expect_code: command exited with 0, we wanted 128 git foo bar clearly makes more sense than test_expect_code: command exited with 0, we wanted 128 from: git foo bar -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Improve legibility of test_expect_code output
Adam Spiers writes:
> ---
No explanation why this is a good idea, nor sign-off?
> t/test-lib-functions.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 t/test-lib-functions.sh
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> old mode 100644
> new mode 100755
> index 8889ba5..e022e73
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -562,7 +562,7 @@ test_expect_code () {
> return 0
> fi
>
> - echo >&2 "test_expect_code: command exited with $exit_code, we wanted
> $want_code $*"
> + echo >&2 "test_expect_code: command exited with $exit_code, we wanted
> $want_code from: $*"
> return 1
> }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
