Re: [PATCH] MSVC: link in invalidcontinue.obj for better POSIX compatibility

2014-03-28 Thread Junio C Hamano 
Marat Radchenko ma...@slonopotamus.org writes:

 This patch fixes crashes caused by quitting from PAGER.

Can you elaborate a bit more on the underlying cause, summarizing
what you learned from this discussion, so that those who read git
log output two weeks from now do not have to come back to this
thread in the mail archive in order to figure out why we suddenly
needs to link with yet another library?

Thanks.

 Signed-off-by: Marat Radchenko ma...@slonopotamus.org
 ---

 Please do not cull the Cc list.

 That was gmane web interface.

 The correct solution is to link against invalidcontinue.obj in the MSVC
 build. This is a compiler-provided object file that changes the default
 behavior to the expected kind, i.e., C runtime functions return EINVAL
 when appropriate instead of crashing the application.

 Thanks for a hint.

  config.mak.uname | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/config.mak.uname b/config.mak.uname
 index 38c60af..8e7ec6e 100644
 --- a/config.mak.uname
 +++ b/config.mak.uname
 @@ -366,7 +366,7 @@ ifeq ($(uname_S),Windows)
   compat/win32/dirent.o
   COMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DNOGDI -DHAVE_STRING_H -Icompat 
 -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\.exe\
   BASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -SUBSYSTEM:CONSOLE 
 -NODEFAULTLIB:MSVCRT.lib
 - EXTLIBS = user32.lib advapi32.lib shell32.lib wininet.lib ws2_32.lib
 + EXTLIBS = user32.lib advapi32.lib shell32.lib wininet.lib ws2_32.lib 
 invalidcontinue.obj
   PTHREAD_LIBS =
   lib =
  ifndef DEBUG
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] MSVC: link in invalidcontinue.obj for better POSIX compatibility

2014-03-28 Thread Junio C Hamano 
Junio C Hamano gits...@pobox.com writes:

 Marat Radchenko ma...@slonopotamus.org writes:

 This patch fixes crashes caused by quitting from PAGER.

 Can you elaborate a bit more on the underlying cause, summarizing
 what you learned from this discussion, so that those who read git
 log output two weeks from now do not have to come back to this
 thread in the mail archive in order to figure out why we suddenly
 needs to link with yet another library?

 Thanks.

Just to avoid getting misunderstood, I am not asking it to be
explained to me in an e-mail.  I want to see a patch with its
proposed commit log message to explain it to readers of git log.

Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html