Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Duy Nguyen
On Sat, Mar 9, 2013 at 7:22 PM, Fredrik Gustafsson wrote: > On Sat, Mar 09, 2013 at 07:05:37PM +0700, Duy Nguyen wrote: >> On Sat, Mar 9, 2013 at 6:08 PM, Fredrik Gustafsson wrote: >> > Actually when implemented a str[n]equal_icase that actually should work. >> > I break the test suite when tryin

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Fredrik Gustafsson
On Sat, Mar 09, 2013 at 07:05:37PM +0700, Duy Nguyen wrote: > On Sat, Mar 9, 2013 at 6:08 PM, Fredrik Gustafsson wrote: > > Actually when implemented a str[n]equal_icase that actually should work. > > I break the test suite when trying to replace > > strncmp_icase(pathname, base, baselen)) on line

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Duy Nguyen
On Sat, Mar 9, 2013 at 6:08 PM, Fredrik Gustafsson wrote: > Actually when implemented a str[n]equal_icase that actually should work. > I break the test suite when trying to replace > strncmp_icase(pathname, base, baselen)) on line 711 in dir.c and I don't > get any significant improvements. Hmm..

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Fredrik Gustafsson
On Sat, Mar 09, 2013 at 05:54:45PM +0700, Duy Nguyen wrote: > On Sat, Mar 9, 2013 at 5:40 PM, Duy Nguyen wrote: > > On Sat, Mar 9, 2013 at 3:42 PM, Fredrik Gustafsson wrote: > >> To improve performance. > > > > BTW, by rolling our own string comparison, we may lose certain > > optimizations done

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Duy Nguyen
On Sat, Mar 9, 2013 at 5:40 PM, Duy Nguyen wrote: > On Sat, Mar 9, 2013 at 3:42 PM, Fredrik Gustafsson wrote: >> To improve performance. > > BTW, by rolling our own string comparison, we may lose certain > optimizations done by C library. In case of glibc, it may choose to > run an sse4.2 version

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Duy Nguyen
On Sat, Mar 9, 2013 at 3:42 PM, Fredrik Gustafsson wrote: > To improve performance. BTW, by rolling our own string comparison, we may lose certain optimizations done by C library. In case of glibc, it may choose to run an sse4.2 version where 16 bytes are compared at a time. Maybe we encounter "s

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Duy Nguyen
On Sat, Mar 09, 2013 at 09:42:54AM +0100, Fredrik Gustafsson wrote: > To improve performance. > git status before: > user0m0.020s > user0m0.024s > user0m0.024s > user0m0.020s > user0m0.024s > user0m0.028s > user0m0.024s > user0m0.024s > user0m0.016s > user0m0

Re: [PATCH] Replace strcmp_icase with strequal_icase

2013-03-09 Thread Fredrik Gustafsson
Please ignore last e-mail. Sorry for the disturbance. -- Med vänliga hälsningar Fredrik Gustafsson tel: 0733-608274 e-post: iv...@iveqy.com -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.