Re: [PATCH] bash prompt: test the prompt with newline in repository path

2013-08-16 Thread Johannes Sixt

Am 16.08.2013 12:36, schrieb SZEDER Gábor:

+repo_with_newline='repo
+with
+newline'
+
+test_expect_success 'prompt - with newline in path' '


This test must be skipped when the filesystem does not support LF in file 
names. Cf. the FUNNYNAMES prerequisite in t3600-rm.sh.



+   printf  (master) expected 
+   git init $repo_with_newline 
+   test_when_finished rm -rf \$repo_with_newline\ 
+   mkdir $repo_with_newline/subdir 
+   (
+   cd $repo_with_newline/subdir 
+   __git_ps1 $actual
+   ) 
+   test_cmp expected $actual
+'


-- Hannes

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] bash prompt: test the prompt with newline in repository path

2013-08-16 Thread Eric Sunshine
On Fri, Aug 16, 2013 at 6:36 AM, SZEDER Gábor sze...@ira.uka.de wrote:
 This subtlety really warrants its own test, especially since I didn't
 explait it in the log message or in an in-code comment back then, so

s/explait/explain/

 add a test to excercise the prompt with newline characters in the path
 to the repository.  Note that 'git rev-parse --git-dir' prints '.git'
 or '.' when at the top of the worktree or the repository,
 respectively, and only prints the full path to the repository when in
 a subdirectory, hence the need for changing into a subdir in the test.

 Signed-off-by: SZEDER Gábor sze...@ira.uka.de
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html