Re: [PATCH] blame: handle broken commit headers gracefully

2013-04-18 Thread Jeff King
On Wed, Apr 17, 2013 at 02:55:29PM -0700, Junio C Hamano wrote: Or you can imagine nastier input strings, like Name -email@host 123456789 - Name ema-il@host 123456789 - Name email@host~ 123456789 - I am afraid that at some point we should salvage as much as we can,

Re: [PATCH] blame: handle broken commit headers gracefully

2013-04-17 Thread Jeff King
On Wed, Apr 17, 2013 at 08:33:54PM +0200, René Scharfe wrote: Minimal patch, test case missing. It's a bit sad that the old commit parser of blame handled Ivan's specific corruption (extra - after email) gracefully because it used the spaces as cutting points instead of and . That may mean

Re: [PATCH] blame: handle broken commit headers gracefully

2013-04-17 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Wed, Apr 17, 2013 at 08:33:54PM +0200, René Scharfe wrote: Minimal patch, test case missing. It's a bit sad that the old commit parser of blame handled Ivan's specific corruption (extra - after email) gracefully because it used the spaces as cutting points