Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread Michael Haggerty
Dmitry, Thanks for your patch. Please see my comments below. On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote: Change install_branch_config() function to use skip_prefix() for getting short name of remote branch. English tweak suggestion: Change THE install_branch_config() function to use

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread David Kastrup
Michael Haggerty mhag...@alum.mit.edu writes: Dmitry, Thanks for your patch. Please see my comments below. On 02/27/2014 12:13 PM, Dmitry S. Dolzhenko wrote: Change install_branch_config() function to use skip_prefix() for getting short name of remote branch. English tweak suggestion:

Re: [PATCH] branch: change install_branch_config() to use skip_prefix()

2014-02-27 Thread Dmitry S. Dolzhenko
Michael, Thank you for your remarks. If you look at what skip_prefix() and starts_with() do, I think you will find that you are doing too much work here. How about this one? const char *shortname = skip_prefix(remote, refs/heads/); int remote_is_branch = shortname != NULL; --