Johannes Schindelin writes:
> Hi Junio,
>
> On Mon, 4 Nov 2013, Junio C Hamano wrote:
>
>> Junio C Hamano writes:
>>
>> > I do not think anybody sane uses prefixcmp() or suffixcmp() for
>> > anything but checking with zero; in other words, I suspect that all
>> > uses of Xcmp() can be replaced
Hi Junio,
On Mon, 4 Nov 2013, Junio C Hamano wrote:
> Junio C Hamano writes:
>
> > I do not think anybody sane uses prefixcmp() or suffixcmp() for
> > anything but checking with zero; in other words, I suspect that all
> > uses of Xcmp() can be replaced with !!Xcmp(), so as a separate
> > clean
Junio C Hamano writes:
> I do not think anybody sane uses prefixcmp() or suffixcmp() for
> anything but checking with zero; in other words, I suspect that all
> uses of Xcmp() can be replaced with !!Xcmp(), so as a separate
> clean-up patch, we may at least want to make it clear that the
> caller
From: Junio C Hamano
Subject: Re: [PATCH] builtin/remote: remove postfixcmp() and use suffixcmp()
instead
Date: Mon, 04 Nov 2013 11:19:43 -0800
> Christian Couder writes:
>
>> Commit 8cc5b290 (git merge -X, 25 Nov 2009) introduced
>> suffixcmp() with nearly the same
Christian Couder writes:
> Commit 8cc5b290 (git merge -X, 25 Nov 2009) introduced
> suffixcmp() with nearly the same implementation as postfixcmp()
> that already existed since commit 211c8968 (Make git-remote a
> builtin, 29 Feb 2008).
This "nearly the same" piqued my curiosity ;-)
The postfix
Christian Couder wrote:
> Commit 8cc5b290 (git merge -X, 25 Nov 2009) introduced
> suffixcmp() with nearly the same implementation as postfixcmp()
> that already existed since commit 211c8968 (Make git-remote a
> builtin, 29 Feb 2008).
[...]
> Signed-off-by: Christian Couder
> ---
> builtin/remo
6 matches
Mail list logo
